Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Is the sw-import.js symlink necessary? #11

Open
justinfagnani opened this issue May 18, 2016 · 2 comments
Open

Is the sw-import.js symlink necessary? #11

justinfagnani opened this issue May 18, 2016 · 2 comments

Comments

@justinfagnani
Copy link

Checking in symlinks seems like a potentially tricky thing.

First, tools need to make sure they understand symlinks. Tedium already has to be updated.

Second, I've heard of problems with checking out symlinks on Windows I'm not sure if they're still problematic, but it'd be nice to confirm that the symlinks work on windows.

Third, the symlink will be invalid when this package is Bower installed, because there won't be a ./bower_components directory.

Are there viable alternate approaches to symlinks?

@rictic
Copy link

rictic commented May 18, 2016

The tedium update was specifically because it's a js file that you can't read (without doing a bower install).

It was easy enough to work around, but it did cause a problem

@cdata
Copy link
Contributor

cdata commented May 18, 2016

I mean, it's a one-line file. The symlink representation in Github is almost as long as the file itself. Is it critical? No. But it's kind of nice not to have to replicate this file everywhere and update n versions if a change is needed. And yes, the location of the file matters.

If we get enough users claiming this won't work for them, let's go ahead and change it. Until then, this is the simplest solution to the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants