Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLIT_64 missing again #66

Closed
breakertt opened this issue Dec 17, 2024 · 2 comments
Closed

SPLIT_64 missing again #66

breakertt opened this issue Dec 17, 2024 · 2 comments

Comments

@breakertt
Copy link
Contributor

This line shouldn't be removed.

Originally posted by @breakertt in 89b1e99

@breakertt
Copy link
Contributor Author

#define SPLIT_64(value) (int) (((__u64) (value)) >> 32), (int) (((__u64) (value)) & 0xffffffff)

was removed again in timetrace.h after commit 89b1e99, which leads to a compilation failure.

@johnousterhout
Copy link
Member

Drat; sorry about that. I will push a fix shortly. This keeps happening because I do my testing with a modified Linux kernel, one of whose header files includes a kernel version of timetrace.h that defines SPLIT_64. Thus it compiled for me. I don't currently have an easy way to compile Homa with an "out of the box" kernel... I need to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants