-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Sectionlist #97
Comments
The refactoring made as part of #93 should make this very easy to add. |
This will actually not be easily possible to do on iOS because of issues described in this comment: #136 (comment) |
Hi @andreialecu , firstly I want to say thank you for this great component! |
@RoscoeZhao unfortunately even though the PR was merged, RN0.64 does not include it. You can verify by comparing https://cdn.jsdelivr.net/npm/react-native@0.64.0/React/Views/RefreshControl/RCTRefreshControl.m with the changes in the PR. The release workflow of RN diverges from what is in master. Instead, they cherry pick commits: RN 0.64.1 is not scheduled to have it either, as per the thread linked above. |
I asked for a cherrypick. If you give the comment some attention, perhaps It'll work ;) |
I guess 30737 finally made it into 0.65 =) |
@andreialecu since the PR is now included in RN 0.65, is there a plan to support sectionlist as well? :) |
Sure, we can consider a PR that adds section list support if anyone is willing to implement it. 🙂 |
Are there some considerations that come into your mind regarding the implementation of SectionList? @andreialecu |
@andreialecu I was able to make |
I commited the PR. Please let me know if anything is missing. Would be happy if the feature could be merged and shipped :) |
Hello, first of all, amazing package. This is something the rn community definetly needs! One question though. Do you plan to support Sectionlist, or is there a way to make it work with sectionlist?
The text was updated successfully, but these errors were encountered: