Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

Add validations to HerokuApplication model #2

Open
hiattp opened this issue May 11, 2018 · 0 comments
Open

Add validations to HerokuApplication model #2

hiattp opened this issue May 11, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@hiattp
Copy link
Contributor

hiattp commented May 11, 2018

From #1:

It'd probably make sense to just add some defensive validations to ensure that any application we create has a name, oauth token, grace period defined.

Also would be kinda good to be able to test that the key works (ie. can authenticate) before it tries to actually trigger a restart.

We should:

  1. Add a db constraint to the name and grace period fields to ensure presence
  2. Ensure we get an exception thrown if the HerokuAppRestarter fails (e.g. due to a bad/missing oauth token). That way we'll be alerted if this isn't working both initially and on an ongoing basis
@hiattp hiattp added the enhancement New feature or request label May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant