You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With our effort to adapt Papirus to KDE Plasma 6 in #3663 we allowed all 16px panel icons to also be used in 32px size. This is needed for Plasma system tray, which uses status icons in a bigger size than their variant for panel:
The problem
However, this lead to some icons showing up in undesirable places, replacing perfectly correct icons such as the case with hard drive icon in file managers and GNOME Disks:
USB reader uses a correct device icon, hard disk icons are replaced by their symbolic variants as of Papirus version 20240501.
That happens because they have the same name: drive-harddisk.svg. This might seem as an oversight, but turns out this is completely fine within the spec: https://specifications.freedesktop.org/icon-theme-spec/latest/#context
Context is everything here. Here is our entry from index.theme for 32px devices folder:
As you can see, the context is correct for this folder. It contains device icons, its context should be device icons.
Now let's see our index.theme entry for new symlinked 32px panel icons:
[32x32/panel]
Context=Status
Size=32
Type=Fixed
They have different context! So the question is, why does the software such as GNOME Disks uses incorrect icons? Does the GTK implementation ignore context? Or is this an issue within Papirus?
So, this issue was created in efforts to investigate the problem and, hopefully, find a solution.
The text was updated successfully, but these errors were encountered:
I mean, there is an implementation that described in specification. If a developer wants to follow the specification, he doesn't have to add context as a parameter for searching an icon.
Background
With our effort to adapt Papirus to KDE Plasma 6 in #3663 we allowed all 16px panel icons to also be used in 32px size. This is needed for Plasma system tray, which uses status icons in a bigger size than their variant for panel:
The problem
However, this lead to some icons showing up in undesirable places, replacing perfectly correct icons such as the case with hard drive icon in file managers and GNOME Disks:
USB reader uses a correct device icon, hard disk icons are replaced by their symbolic variants as of Papirus version 20240501.
That happens because they have the same name: drive-harddisk.svg. This might seem as an oversight, but turns out this is completely fine within the spec: https://specifications.freedesktop.org/icon-theme-spec/latest/#context
Context is everything here. Here is our entry from index.theme for 32px devices folder:
[32x32/devices]
Context=Devices
Size=32
Type=Fixed
As you can see, the context is correct for this folder. It contains device icons, its context should be device icons.
Now let's see our index.theme entry for new symlinked 32px panel icons:
[32x32/panel]
Context=Status
Size=32
Type=Fixed
They have different context! So the question is, why does the software such as GNOME Disks uses incorrect icons? Does the GTK implementation ignore context? Or is this an issue within Papirus?
So, this issue was created in efforts to investigate the problem and, hopefully, find a solution.
The text was updated successfully, but these errors were encountered: