Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kmymoney icons #1629

Closed
jEsuSdA opened this issue Feb 9, 2019 · 16 comments
Closed

Kmymoney icons #1629

jEsuSdA opened this issue Feb 9, 2019 · 16 comments

Comments

@jEsuSdA
Copy link
Contributor

jEsuSdA commented Feb 9, 2019

Hi!

There is an app KmyMoney icons, but It will be great complete all the icons KmyMoney uses in his interface.

Nowadays KmyMoney loads some Papirus Icons, but some other are not existing.

Maybe some of them could be done with a simple symlink.

Here the icons:

account
account

account-types-asset
account-types-asset

account-types-cash
account-types-cash

account-types-checking
account-types-checking

account-types-credit-card
account-types-credit-card

account-types-investments
account-types-investments

account-types-liability
account-types-liability

account-types-loan
account-types-loan

account-types-savings
account-types-savings

budget
budget

categories
categories

forecast
forecast

home
home

institution
institution

investment
investment

ledger
ledger

online-banking
online-banking

payee
payee

report
report

schedule
schedule

The complete icon theme (in from /usr/share/kmymoney/icons/hicolors):
hicolor.zip

And here, how it looks like now:

imagen

As you can see, some icons (calcultaor, categories, delete, ...) are from Papirus cause KmyMoney tries to load the icons from the desktop theme.

Thanks a lot!

@varlesh
Copy link
Contributor

varlesh commented Feb 9, 2019

@jEsuSdA left sidebar icons hardcoded? You can check this please?Added any symlink for one icon

@varlesh
Copy link
Contributor

varlesh commented Feb 9, 2019

for example:

cd /usr/share/icons/Papirus/22x22/actions
sudo ln -s go-home.svg home.svg

@jEsuSdA
Copy link
Contributor Author

jEsuSdA commented Feb 9, 2019

@varlesh

It works
imagen

But no with 22x22 icons, but symbolic:

I did

cd /usr/share/icons/Papirus/22x22/actions
sudo ln -s go-home.svg home.svg

and didn't work

I did

cd /usr/share/icons/Papirus/symbolic/actions
ln -s go-home-symbolic.svg home.svg

and this worked!

Maybe adding a ACTION folder in 64x64 size pixel folder of Papitus should work.

@varlesh
Copy link
Contributor

varlesh commented Feb 9, 2019

KDE not use symbolic icons

@jEsuSdA
Copy link
Contributor Author

jEsuSdA commented Feb 9, 2019

@varlesh Yes, I know.

What I mean is that doing symlinks in 22x22 folder does not works, but doing the symlinks in symbolic folder do it.

I supppose that creating a ACTION folder into 64x64 size will work too.

@varlesh
Copy link
Contributor

varlesh commented Feb 9, 2019

It's not hardcoded and this very good. But our symbolic icons not support kde color scheme css and this bad way...

@jEsuSdA
Copy link
Contributor Author

jEsuSdA commented Feb 9, 2019

@varlesh
The thing is not to use symbolic, but colorful ones into 64x64 Papirus folder. I think. ;)

varlesh added a commit that referenced this issue Feb 22, 2019
@SmartFinn Colorized 32px actions icons, index.theme updated. Need fix script?
varlesh added a commit that referenced this issue Feb 22, 2019
varlesh added a commit that referenced this issue Feb 22, 2019
varlesh added a commit that referenced this issue Feb 22, 2019
@varlesh
Copy link
Contributor

varlesh commented Feb 22, 2019

@jEsuSdA Please report bug on KMyMoney for rendering icons on toolbar....
Mostly icons on toolbar not rendered normal:
image
See example icon account (yellow icon) - this icon have monochrome version too, but why rendered 32px for toolbar with 22px? It's bug!!!

@jEsuSdA
Copy link
Contributor Author

jEsuSdA commented Mar 1, 2019

@varlesh good job!

I fired the bug to KmyMoney team.

In my case, the icon inconsistency is worse than you, cause there are a mixture of color and symbolic icons in the left pannel.

imagen

And, of course, in the main toolbar, like you:

imagen

Here the KmyMoney bug:
https://bugs.kde.org/show_bug.cgi?id=404959

Thanks a lot, @varlesh. I love the new icons you made. ;)

@wrobelda
Copy link

Thanks for reporting this issue, I am looking into it.

Nice icons, BTW!

@wrobelda
Copy link

wrobelda commented Mar 1, 2021

Hi,

Please look at the changes in master branch regarding icons. Many of them were renamed, many new colorful icons were added to their symbolic counterparts and their usage within the app is now more consistent. Specifically, you want to look at:

@varlesh
Copy link
Contributor

varlesh commented Mar 1, 2021

@wrobelda It's will be solved on next release?

varlesh added a commit that referenced this issue Mar 1, 2021
@wrobelda
Copy link

wrobelda commented Mar 1, 2021

@varlesh The upcoming 5.1.x maintenance release will have most of the known issues with icons unresolved. All icon issues are fixed in master and we hope to have a release sometime in Q2 this year.

varlesh added a commit that referenced this issue Mar 1, 2021
@varlesh
Copy link
Contributor

varlesh commented Mar 1, 2021

for me
monochrome icons:

  • office-chart-line-forecast
  • office-report
  • tag-edit
  • view-currency-list
  • view-financial-account-add
  • view-financial-account-asset-closed
  • view-financial-account-asset
  • view-financial-account-cash-closed
  • view-financial-account-cash
  • view-financial-account-checking-closed
  • view-financial-account-checking
  • view-financial-account-close
  • view-financial-account-closed
  • view-financial-account-credit-card-closed
  • view-financial-account-credit-card
  • view-financial-account-delete
  • view-financial-account-edit
  • view-financial-account-investment-closed
  • view-financial-account-investment-security-closed
  • view-financial-account-investment-security
  • view-financial-account-investment
  • view-financial-account-liability-closed
  • view-financial-account-liability
  • view-financial-account-loan-closed
  • view-financial-account-loan
  • view-financial-account-reopen
  • view-financial-account-savings-closed
  • view-financial-account-savings
  • view-financial-account
  • view-financial-budget
  • view-financial-category-add
  • view-financial-category-delete
  • view-financial-category-edit
  • view-financial-category-expense
  • view-financial-category-income
  • view-financial-list
  • view-financial-transfer-reconcile
  • view-financial-transfer-reconciled
  • view-financial-transfer-unreconciled
  • view-institution-add
  • view-institution-delete
  • view-institution-edit
  • view-institution

kmymoney.zip

varlesh added a commit that referenced this issue Mar 1, 2021
varlesh added a commit that referenced this issue Mar 1, 2021
@varlesh varlesh closed this as completed Mar 1, 2021
@varlesh
Copy link
Contributor

varlesh commented Mar 1, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants