-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Skip Early CFG does not affect the image output at all #9
Comments
also i checked if it passed in the condition if skip_uncond:
# Ensure we keep at least one element
print('Test 1')
if x.shape[0] > 1:
print('Test 2')
x = x[:-1]
sigma = sigma[:-1]
assert x.numel() > 0 and sigma.numel() > 0, "x or sigma became empty after skip_uncond" sd_sampler_cfg_denoiser.py line 321-327 |
Thanks for the report, I'm a bit busy at the moment but will check it out when I have time. |
I have added a new commit that should fix this, can you try and see if it works? ea29f74 |
Tested it out, seems to work now i guess, thank you. |
Yes please, to have separated issues, gonna close this one. |
Checklist
What happened?
The Skip Early CFG Feature / Ignore negative prompt during early sampling (skip_early_cond) does not affect the image output at all.
Steps to reproduce the problem
Generate two images, one with skip_early_cond at 0 and one with it at 1.0
What should have happened?
according to the pull request adding the feature on auto webui : AUTOMATIC1111/stable-diffusion-webui#15607
it should at least affect the image a little
What browsers do you use to access the UI ?
No response
Sysinfo
sysinfo-2024-07-12-10-45.json
Console logs
Additional information
skip_early cond at 1.0 (enabled):
skip_early_cond at 0.0 (disabled):
The text was updated successfully, but these errors were encountered: