Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/resolvers/Mutation/removeEventProject.ts #901

Closed
palisadoes opened this issue Jan 24, 2023 · 7 comments
Closed

Test: src/lib/resolvers/Mutation/removeEventProject.ts #901

palisadoes opened this issue Jan 24, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/resolvers/Mutation/removeEventProject.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/resolvers/Mutation/removeEventProject.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@rv602
Copy link
Contributor

rv602 commented Jan 24, 2023

@palisadoes I would like to work on this issue.

@github-actions
Copy link

This issue did not get any activity in the past 14 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 10, 2023
@KrutikaBhatt
Copy link
Contributor

Hey @palisadoes, is this issue still open? Can I work on this?

@palisadoes
Copy link
Contributor Author

@rv602 I'm going to reassign this. Please focus on the GitHub Actions issue.

@palisadoes palisadoes assigned KrutikaBhatt and unassigned rv602 Feb 13, 2023
@palisadoes palisadoes removed the no-issue-activity No issue activity label Feb 13, 2023
@rv602
Copy link
Contributor

rv602 commented Feb 13, 2023

@palisadoes okay will do.
I'm sorry for not being much active nowadays due to my examinations.
I will resume my work shortly. Thank you.

@KrutikaBhatt
Copy link
Contributor

@palisadoes, the tests were already covered for resolvers/Mutation/removeEventProject.js and the code coverage is obtained to 100%. I think this issue is already resolved and it can be closed

image

@palisadoes
Copy link
Contributor Author

Thanks. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

No branches or pull requests

3 participants