Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create tests for src/lib/directives/authDirective.ts #793

Closed
SiddheshKukade opened this issue Dec 5, 2022 · 1 comment
Closed
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request

Comments

@SiddheshKukade
Copy link
Member

SiddheshKukade commented Dec 5, 2022

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file src/lib/directives/authDirective.ts

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/directive/authDirective.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Dec 5, 2022
@SiddheshKukade SiddheshKukade added points 01 unapproved Unapproved for Pull Request and removed unapproved Unapproved for Pull Request feature request parent Parent issue labels Dec 5, 2022
@palisadoes palisadoes changed the title Resolvers: Create tests for authDirective.js Resolvers: Create tests for src/lib/directives/authDirective.ts Jan 24, 2023
@palisadoes palisadoes added the good first issue Good for newcomers label Jan 24, 2023
@noman2002 noman2002 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2023
@noman2002
Copy link
Member

noman2002 commented Jan 29, 2023

Duplicate of #797

@noman2002 noman2002 marked this as a duplicate and then as not a duplicate of #794 Jan 29, 2023
@noman2002 noman2002 marked this as a duplicate of #797 Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants