Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/resolvers/Mutation/createMember.ts #1824

Closed
palisadoes opened this issue Feb 8, 2024 · 15 comments
Closed

Test: src/resolvers/Mutation/createMember.ts #1824

palisadoes opened this issue Feb 8, 2024 · 15 comments
Assignees
Labels
feature request parent Parent issue test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  1. Tests need to be written for file src/resolvers/Mutation/createMember.ts
  2. We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  3. When complete, all all methods, classes and/or functions in the refactored file will need to be tested.
  4. These tests must be placed in a single file with the same path as the tested file, but under the tests/ with a .spec.ts suffix.
  5. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.

Other

Please coordinate issue assignment and PR reviews with the contributors listed in this issue:

@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 8, 2024
@YashGupta2111
Copy link

I would like to work on this.

@NamitBhutani
Copy link
Contributor

@YashGupta2111 Currently the check where a member is already a part of the organization is failing and the code is again adding the member to the organization ( even if they are already a member). This bug was somehow ignored by the current tests, while refactoring errors in my PR, I found this out.

@NamitBhutani
Copy link
Contributor

Is there any update?

@YashGupta2111
Copy link

I am working on it

@YashGupta2111 YashGupta2111 removed their assignment Feb 14, 2024
@Shubh152
Copy link

Shubh152 commented Feb 14, 2024

Please assign this issue to me if available

@Cioppolo14
Copy link
Contributor

@Shubh152 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@manishjha-04
Copy link

@Cioppolo14 can I work on this?

@Shubh152
Copy link

@Shubh152 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

Sure, I will keep that in mind. Sorry for the trouble caused.

@Cioppolo14
Copy link
Contributor

@manishjha-04 Checking to see if you are working on this, as it is holding up another issue.

@manishjha-04
Copy link

Hey @Cioppolo14 I am sorry but I might not be able to make it on time ! I am unassigning myself !

@manishjha-04 manishjha-04 removed their assignment Feb 23, 2024
@Doraemon012
Copy link
Member

@palisadoes , @Cioppolo14
I would like to work on this. Please assign this to me.

@AdityaRaimec22
Copy link
Contributor

Can i get assigned to the issue.

Copy link

github-actions bot commented Mar 6, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 6, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Mar 6, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to no activity or open PR.

@Manik2708
Copy link
Contributor

Can I work on this issue? @Cioppolo14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request parent Parent issue test Testing application
Projects
None yet
Development

No branches or pull requests

9 participants