Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/OrganizationEvents #2514

Closed
AVtheking opened this issue Nov 30, 2024 · 6 comments
Closed

Refactor CSS files in src/screens/OrganizationEvents #2514

AVtheking opened this issue Nov 30, 2024 · 6 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/OrganizationEvents

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@harshk-89
Copy link

I have started working on it. I will finish my work as soon as possible. Please assign it to me @palisadoes .

@harshk-89
Copy link

Please review the approach I have followed. If there are any inconsistencies, I am open to addressing them. My approach is as follows:

  1. Update CSS Import Path:
    I updated the import path in the relevant files from ./organizationEvents.module.css to import styles from '../../style/app.module.css';.

  2. Identify Similarities and Conflicts:
    I carefully analyzed the styles in both app.module.css and organizationEvents.module.css to identify overlapping or similar CSS rules. For entries that were similar, I created a parent class to properly scope the styles. This ensured that there were no conflicts between styles and that the functionality of both components remained intact.

  3. Handle Redundancies:
    While reviewing organizationEvents.module.css, I discovered several redundant styles, such as duplicate CSS rules applied to multiple elements. I consolidated these redundant entries to streamline the CSS, improving maintainability and reducing unnecessary duplication.

Final Outcome:
I migrated all CSS rules from organizationEvents.module.css to app.module.css, eliminating the dependency on organizationEvents.module.css. This change removed the reliance on local CSS within the organizationEvents directory and made the component dependent on the global CSS file (app.module.css).

@palisadoes
Copy link
Contributor

Please open a PR and let the reviewers decide

@palisadoes
Copy link
Contributor

With this issue we are migrating from the previous green based color scheme where the #31bb6b color was used for many elements to one using a color scheme similar to that of Gmail.

This makes the app more usable for people with red/green color blindness

When making your changes, make the effort to use pre-existing colors in the src/style/app.module.css file.

@harshk-89
Copy link

Okay, I will take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants