Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conduit lengths should throw warning if negative #2557

Open
mkaguer opened this issue Aug 29, 2022 · 0 comments · May be fixed by #2740
Open

Conduit lengths should throw warning if negative #2557

mkaguer opened this issue Aug 29, 2022 · 0 comments · May be fixed by #2740

Comments

@mkaguer
Copy link
Contributor

mkaguer commented Aug 29, 2022

I was using spheres_and_cylinders model and got negative conduit lengths. There was no error thrown until it was noticed that I had nans in my conductance. I had to trace that error all the way back to find a problem with conduit lengths. And in my exact case, the conduit lengths were negative because of overlapping pores where the pore center of the one pore was inside the other. I think this should be caught when conduit lengths are calculated. Just do a quick check for any negative conduit lengths and throw a warning at least.

@jgostick jgostick added this to the v3+ - Future Maintenance milestone Sep 21, 2022
@jgostick jgostick linked a pull request Apr 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants