-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate refresh_token
#71
Comments
Let's put this on 2.x. |
+1 on this, feeling confused since usually i implement oauth based on the spec, then found out there is no dedicated |
Ok, if no one gets this to start developing I'll try to get this on this weekend to start developing and open the PR for us. @leon0399 if you already started working on this you can open the PR as a draft and we can help you as well too. |
Would the target be 1.x or 2.x? I mean are we expecting (hard to say before coding, right? 😅) incompatible changes for old package transitions? 🤔 |
Let's move discussion regarding future incompatible changes somewhere else. This change is definetely breaking (atleasr how I see it) I've started new discussion |
As of now let's close it since there's no further discussion about it. |
Subject of the issue
Refresh token should be different from
access_token
. It does not only provide security vulnerability, but also a lot of misunderstandments (tymondesigns/jwt-auth#1105, tymondesigns/jwt-auth#2149, tymondesigns/jwt-auth#2116 are one of MANY), event Tymon mentioned this is needed at some point (tymondesigns/jwt-auth#1105 (comment))Changing this behaviour can be a breaking change, so this feature might be planned for some kind of
2.0
versionExpected behaviour
You have to use different token to refresh your
access_token
Actual behaviour
You have to usesame token to authenticate your requests and refresh your existing
access_token
The text was updated successfully, but these errors were encountered: