Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate refresh_token #71

Closed
leon0399 opened this issue Nov 24, 2021 · 7 comments
Closed

Separate refresh_token #71

leon0399 opened this issue Nov 24, 2021 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@leon0399
Copy link
Member

leon0399 commented Nov 24, 2021

Subject of the issue

Refresh token should be different from access_token. It does not only provide security vulnerability, but also a lot of misunderstandments (tymondesigns/jwt-auth#1105, tymondesigns/jwt-auth#2149, tymondesigns/jwt-auth#2116 are one of MANY), event Tymon mentioned this is needed at some point (tymondesigns/jwt-auth#1105 (comment))

Changing this behaviour can be a breaking change, so this feature might be planned for some kind of 2.0 version

Expected behaviour

You have to use different token to refresh your access_token

Actual behaviour

You have to usesame token to authenticate your requests and refresh your existing access_token

@leon0399 leon0399 added the enhancement New feature or request label Nov 24, 2021
@Messhias
Copy link
Collaborator

Let's put this on 2.x.

@dexcell
Copy link

dexcell commented Nov 26, 2021

+1 on this, feeling confused since usually i implement oauth based on the spec, then found out there is no dedicated refresh_token using jwt-auth lib

@Messhias
Copy link
Collaborator

+1 on this, feeling confused since usually i implement oauth based on the spec, then found out there is no dedicated refresh_token using jwt-auth lib

Ok, if no one gets this to start developing I'll try to get this on this weekend to start developing and open the PR for us.

@leon0399 if you already started working on this you can open the PR as a draft and we can help you as well too.

@mfn
Copy link
Contributor

mfn commented Nov 26, 2021

Would the target be 1.x or 2.x? I mean are we expecting (hard to say before coding, right? 😅) incompatible changes for old package transitions? 🤔

@leon0399
Copy link
Member Author

Would the target be 1.x or 2.x? I mean are we expecting (hard to say before coding, right? 😅) incompatible changes for old package transitions? 🤔

Let's move discussion regarding future incompatible changes somewhere else. This change is definetely breaking (atleasr how I see it)

I've started new discussion

@Messhias
Copy link
Collaborator

Messhias commented May 5, 2022

As of now let's close it since there's no further discussion about it.

@Messhias Messhias closed this as completed May 5, 2022
@lakuapik
Copy link

Hi @leon0399 @Messhias just asking, has this been brought to v2.x? I am looking for a documentation, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants