Drop support for older Laravel and PHP versions

[leon0399]

Dropping support for older versions will allow to make this package more secure and easier to use at the same time.

I don't think, that those, who use these old versions are willing to update only JWT package

Since 8.x is the only supported version, and even 6.x (LTS) is also dropped it's support, we can leave only latest versions (^8) and PHP 7.3+

[Messhias]

Dropping support for older versions will allow making this package more secure and easier to use at the same time.

I don't think, that those, who use these old versions are willing to update only the JWT package

Since 8. x is the only supported version, and even 6. x (LTS) is also dropped its support, we can leave only the latest versions (^8) and PHP 7.3+

Me and @eschricker we talked about that in the slack channel to drop it, but we need to refactor some code also to be compatible with 7.3+ versions.

Do you want to open the PR to drop the versions?

Thank you,

[leon0399]

Yes, I'll try to find my time updating this project this weekend!

[eschricker]

We discussed the support for versions here #29 (comment)

TLDR: 6.x is supported till September 2022, 7.x is out of support, 8.x is supported till January 2023.

With the last release 1.2.0 we dropped the support for Laravel 5, but we keep the support for 6, 7 and 8

[Messhias]

@leon0399 I guess as @eschricker told you concerning #29 , I believe we can close this thread. Shall we?

[leon0399]

@leon0399 I guess as @eschricker told you concerning #29 , I believe we can close this thread. Shall we?

Regarding Laravel versions - understandable

But latest versions of lcobucci/jwt requires PHP ^7.4, so there is no reason to keep PHP version lower

[Messhias]

@leon0399 I guess as @eschricker told you concerning #29 , I believe we can close this thread. Shall we?

Regarding Laravel versions - understandable

But latest versions of lcobucci/jwt requires PHP ^7.4, so there is no reason to keep PHP version lower

Yes, but this is just one package, there are other packages that compose the whole library that should be taken into consideration too.

[leon0399]

@leon0399 I guess as @eschricker told you concerning #29 , I believe we can close this thread. Shall we?

Regarding Laravel versions - understandable
But latest versions of lcobucci/jwt requires PHP ^7.4, so there is no reason to keep PHP version lower

Yes, but this is just one package, there are other packages that compose the whole library that should be taken into consideration too.

It would've made sense, if it was optional dependency. But rigth now trying to install this package on PHP 7.2 fails with given error:

/var/www/html # php -v
PHP 7.2.34 (cli) (built: Dec 17 2020 10:26:11) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies

/var/www/html # composer require php-open-source-saver/jwt-auth
Using version ^1.2 for php-open-source-saver/jwt-auth
./composer.json has been updated
Running composer update php-open-source-saver/jwt-auth
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - lcobucci/jwt[4.0.0, ..., 4.1.5] require php ^7.4 || ^8.0 -> your php version (7.2.34) does not satisfy that requirement.
    - php-open-source-saver/jwt-auth 1.2.0 requires lcobucci/jwt ^4.0 -> satisfiable by lcobucci/jwt[4.0.0, ..., 4.1.5].
    - Root composer.json requires php-open-source-saver/jwt-auth ^1.2 -> satisfiable by php-open-source-saver/jwt-auth[1.2.0].


Installation failed, reverting ./composer.json to its original content.

We should decide, either we make both lcobucci/jwt and namshi/jose optional dependencies by moving them to suggest section.
Or leave lcobucci/jwt as is and update base language version and drop namshi/jose, since it is deprecated, which would be better, I guess

[leon0399]

Unfortunately, it wasn't auto-closed when #52 was merged. Should we close it now?

[Messhias]

Unfortunately, it wasn't auto-closed when #52 was merged. Should we close it now?

Sure.

Merged at #52.