New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shapes.scad: Winding order is inconsistent #7

Open

usedbytes opened this issue Jan 6, 2018 · 0 comments

usedbytes commented Jan 6, 2018 •

edited

Loading

In shapes.scad, the winding order of the shapes are inconsistent.

square(): clockwise
circle(): anti-clockwise
regular(): anti-clockwise (as it uses circle())
rectangle_profile(): anti-clockwise

This causes trouble when sweep()-ing (as in https://github.com/openscad/list-comprehension-demos/blob/master/sweep.scad) circle(), as the normals of the resulting polygon end up pointing inwards instead of outwards.

It would probably make sense to make all of the shapes have anti-clockwise winding order, to match the OpenSCAD polyhedron expectations.

(btw, I'm happy to submit a pull request to fix it if you agree)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment