Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile in recent versions #7

Closed
deingithub opened this issue Oct 2, 2019 · 1 comment · Fixed by #8
Closed

Fails to compile in recent versions #7

deingithub opened this issue Oct 2, 2019 · 1 comment · Fixed by #8
Assignees
@OscarBarrett

Comments

@deingithub
Copy link

deingithub commented Oct 2, 2019 •
edited
Loading

Since the merge of crystal-lang/crystal#7581, the library can't compile anymore due to usage of Slice#pointer in https://github.com/OscarBarrett/crystal-sha3/blob/master/src/digest/sha3.cr#L70.

Also, https://github.com/OscarBarrett/crystal-sha3/blob/master/src/digest/sha3.cr#L82 needs to use // because the / operator now returns floats instead of integers.
@OscarBarrett OscarBarrett self-assigned this Oct 3, 2019
@OscarBarrett
Copy link
Owner

Thanks for reporting - I'll do up a fix for those changes.

@OscarBarrett OscarBarrett mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OscarBarrett OscarBarrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Remove usage of Slice#pointer, update Int#/ usage (#7) OscarBarrett/crystal-sha3
2 participants
@OscarBarrett @deingithub