IDetectRobots injection into tag helper constructor

[xperiandri]

@MatthijsKrempel, @jtkech, @hishamco, @agriffard, do you know why IDetectRobots is not just injected into the constructor?

OrchardCore/src/OrchardCore/OrchardCore.ReCaptcha.Core/TagHelpers/ReCaptchaTagHelper.cs

Line 54 in 7e8a753

var robotDetectors = _httpContextAccessor.HttpContext.RequestServices.GetServices<IDetectRobots>();

[hishamco]

I think it should, I don't see any reason to leave it there

[hishamco]

I realize this is needed to get all the registed instances of IDetectRobots, but I think we could inject IEnumerable<IDetectRobots> instead

[xperiandri]

Looks like we can go that way https://medium.com/agilix/asp-net-core-inject-all-instances-of-a-service-interface-64b37b43fdc8
We will try. Thanks

[MatthijsKrempel]

Try it and find out, I can’t remember, something vaguely about lifetime registration rings a bell.

[hishamco]

May be this line

OrchardCore/src/OrchardCore/OrchardCore.ReCaptcha.Core/ActionFilters/Detection/IpAddressRobotDetector.cs

Line 36 in 7e8a753

return _httpContext.Connection.RemoteIpAddress.ToString();

/cc @jtkech @Skrypt

[Skrypt]

Probably an exception here where we need absolutely to use the current httpContext.
Though I understand the concern since we should try to avoid injecting the HttpContext as much as we can.