Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI builds from TeamCity to GitHub Actions #8683

Closed
BenedekFarkas opened this issue May 15, 2023 · 5 comments
Closed

Migrate CI builds from TeamCity to GitHub Actions #8683

BenedekFarkas opened this issue May 15, 2023 · 5 comments
Assignees
Milestone

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented May 15, 2023

CI builds are currently executed by the public TeamCity server provided by JetBrains for free for OSS. Let's move everything to GitHub Actions for better integration (with GH) and maintainability, potentially also adding PR builds.

Current builds are structured as follows (each of them restore NuGet packages and then call a specific target on Orchard.proj):

  1. Main builds
    1. Continuous build - Major version: dev branch on every commit, "Build" target.
    2. Continuous build - Major version: 1.10.x branch on every commit, "Build" target.
    3. Nightly build - Major version: dev branch at midnight, "Spec" target.
    4. Nightly build - Major version: 1.10.x branch at midnight, "Spec" target.
    5. Release: master branch on every commit, "Build" target, zip packages (Source and Web distribution) published as artifact.
  2. Major version (dev branch at midnight):
    1. Build and SpecFlow Tests: "Compile" target, then calling NUnit on *.Specs.*.dll.
    2. Build and Unit Tests: "Compile" target, then calling NUnit on *.Tests.*.dll.
  3. Minor version: Same as the previous, but 1.10.x branch.
@BenedekFarkas BenedekFarkas modified the milestones: dev, 1.10.x May 15, 2023
@BenedekFarkas BenedekFarkas self-assigned this May 15, 2023
@BenedekFarkas
Copy link
Member Author

BenedekFarkas commented May 15, 2023

There are a few dozen unit tests that are failing to initialize due to breaking changes as well as a dozen or so that are failing the assertion, so I'm working on those too.

@BenedekFarkas
Copy link
Member Author

BenedekFarkas commented May 15, 2023

I've paused the whole project in TC for now, because missing tooling causes all the builds to fail.

@sebastienros
Copy link
Member

I've paused the whole project in TC for now

May as well delete it, it just doesn't work and we'll never use it again

@BenedekFarkas
Copy link
Member Author

Sure, we don't need it anymore when the GitHub Actions migration is complete. I'm just keeping it as a backup for now - it would be better to have something to compare the results with, but we probably won't be able to get it working again.

@BenedekFarkas
Copy link
Member Author

Fixed as part of #8686 and #8684, see this comment: #8686 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants