Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Make separate liveness/readiness probes possible #277

Closed
toffer opened this issue Nov 12, 2020 · 0 comments · Fixed by #278
Closed

Make separate liveness/readiness probes possible #277

toffer opened this issue Nov 12, 2020 · 0 comments · Fixed by #278

Comments

@toffer
Copy link
Contributor

toffer commented Nov 12, 2020

Feature Request

Is your feature request related to a problem? Please describe.

I'd like to make it possible to have different scripts for the liveness and readiness probes. As of #234, the LivenessProbe command in the cassandra container PodTemplateSpec is hard-coded to point to /etc/readiness-probe.sh, so there's no way to have separate scripts.

Describe the solution you'd like to see

If we add liveness-probe.sh to the bootstrap Docker image, but make it a symlink to readiness-probe.sh, then we can keep the current behavior, where we use the same script for both probes. And, this also makes it possible to override this behavior and define a separate script for each probe.

Describe alternatives you've considered

Rather than use a symlink, we could cut/paste the contents of readiness-probe.sh into liveness-probe.sh. But, using the symlink makes it more obvious that we are using the same script for both probes (in the default case).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant