Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ECDSA.recover revert on failure #1978

Closed
nventuro opened this issue Oct 30, 2019 · 0 comments · Fixed by #2114
Closed

Make ECDSA.recover revert on failure #1978

nventuro opened this issue Oct 30, 2019 · 0 comments · Fixed by #2114
Labels
breaking change Changes that break backwards compatibility of the public API.
Milestone
v3.0

Comments

@nventuro
Copy link
Contributor

recover returning the zero address instead of reverting, while consistent with the behavior of ecrecover, is wildly inconsistent with the rest of the library. We should follow the principle of least surprise and bring it in line with other functions.
@nventuro nventuro added the breaking change Changes that break backwards compatibility of the public API. label Oct 30, 2019
@nventuro nventuro added this to the v3.0 milestone Oct 30, 2019
@nventuro nventuro mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Make ECDSA.recover revert on error. nventuro/openzeppelin-contracts
1 participant
@nventuro