From 88ca19d93cb348c9ba11bb8f5b332d1f6faa5768 Mon Sep 17 00:00:00 2001 From: miro Date: Thu, 16 Jan 2025 03:52:14 +0000 Subject: [PATCH 1/2] fix:runtime_lang --- ovos_dinkum_listener/plugins.py | 1 + ovos_dinkum_listener/voice_loop/voice_loop.py | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ovos_dinkum_listener/plugins.py b/ovos_dinkum_listener/plugins.py index 23d0272..0180532 100644 --- a/ovos_dinkum_listener/plugins.py +++ b/ovos_dinkum_listener/plugins.py @@ -74,6 +74,7 @@ def transcribe(self, audio: Optional[Union[bytes, AudioData]] = None, audiod = audio else: raise ValueError(f"'audio' must be 'bytes' or 'AudioData', got '{type(audio)}'") + LOG.debug(f"Transcribing with lang: {lang}") return self.engine.transcribe(audiod, lang) diff --git a/ovos_dinkum_listener/voice_loop/voice_loop.py b/ovos_dinkum_listener/voice_loop/voice_loop.py index f538fcf..1d34b8b 100644 --- a/ovos_dinkum_listener/voice_loop/voice_loop.py +++ b/ovos_dinkum_listener/voice_loop/voice_loop.py @@ -700,6 +700,7 @@ def _get_tx(self, stt_context: dict) -> (str, dict): @return: string transcription and dict context """ # handle lang detection from speech + lang = self.stt.lang if "stt_lang" in stt_context: lang = self._validate_lang(stt_context["stt_lang"]) stt_context["stt_lang"] = lang @@ -711,7 +712,7 @@ def _get_tx(self, stt_context: dict) -> (str, dict): # get text and trigger callback try: - utts = self.stt.transcribe() or [] + utts = self.stt.transcribe(lang=lang) or [] except: LOG.exception("STT failed") utts = [] @@ -719,7 +720,7 @@ def _get_tx(self, stt_context: dict) -> (str, dict): if not utts and self.fallback_stt is not None: LOG.info("Attempting fallback STT plugin") try: - utts = self.fallback_stt.transcribe() or [] + utts = self.fallback_stt.transcribe(lang=lang) or [] except: LOG.exception("Fallback STT failed") From 67cb740a58337c78e5a5cf3f97791e3bd6994705 Mon Sep 17 00:00:00 2001 From: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Date: Thu, 16 Jan 2025 04:01:29 +0000 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- ovos_dinkum_listener/voice_loop/voice_loop.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ovos_dinkum_listener/voice_loop/voice_loop.py b/ovos_dinkum_listener/voice_loop/voice_loop.py index 1d34b8b..53bfc78 100644 --- a/ovos_dinkum_listener/voice_loop/voice_loop.py +++ b/ovos_dinkum_listener/voice_loop/voice_loop.py @@ -713,7 +713,8 @@ def _get_tx(self, stt_context: dict) -> (str, dict): # get text and trigger callback try: utts = self.stt.transcribe(lang=lang) or [] - except: + except Exception as e: + LOG.exception(f"Primary STT transcription failed: {str(e)}") LOG.exception("STT failed") utts = [] @@ -721,7 +722,8 @@ def _get_tx(self, stt_context: dict) -> (str, dict): LOG.info("Attempting fallback STT plugin") try: utts = self.fallback_stt.transcribe(lang=lang) or [] - except: + except Exception as e: + LOG.exception(f"Fallback STT transcription failed: {str(e)}") LOG.exception("Fallback STT failed") if not utts: