From f51515a4272fb2f5d4c78f0f6e584ec78c988fc6 Mon Sep 17 00:00:00 2001 From: paulmwatson Date: Wed, 24 Jan 2024 15:23:50 +0200 Subject: [PATCH] Dynamic GTM and GA4 settings --- config/config.py | 3 ++- docker-compose.yml | 2 ++ pmg/templates/layout.html | 4 ++-- pmg/utils.py | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/config/config.py b/config/config.py index e1209aad..7888849f 100644 --- a/config/config.py +++ b/config/config.py @@ -13,7 +13,8 @@ WTF_CSRF_ENABLED = False if TEST else True SECRET_KEY = env.get("FLASK_SECRET_KEY", "NSTHNSTHaoensutCGSRCGnsthoesucgsrSNTH") -GOOGLE_ANALYTICS_ID = "G-EBG7VD75NV" +GOOGLE_ANALYTICS_ID = env.get("GOOGLE_ANALYTICS_ID", None) +GOOGLE_TAG_MANAGER_ID = env.get("GOOGLE_TAG_MANAGER_ID", None) SQLALCHEMY_DATABASE_URI = env.get( "SQLALCHEMY_DATABASE_URI", diff --git a/docker-compose.yml b/docker-compose.yml index 1ef70f89..6ade244b 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -29,6 +29,8 @@ services: - REDIS_URL=redis://redis:6379/0 - SQLALCHEMY_DATABASE_URI=postgresql://pmg:pmg@postgres/pmg?client_encoding=utf8 - ES_SERVER=http://elastic:9200 + - GOOGLE_ANALYTICS_ID=G-XN8MJJNSEE + - GOOGLE_TAG_MANAGER_ID=GTM-MMCNPLT6 ports: - "5000:5000" command: python app.py runserver diff --git a/pmg/templates/layout.html b/pmg/templates/layout.html index 3246f605..fd2a7faf 100644 --- a/pmg/templates/layout.html +++ b/pmg/templates/layout.html @@ -49,7 +49,7 @@ new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); - })(window,document,'script','dataLayer','GTM-W7T6ZWH7'); + })(window,document,'script','dataLayer','{{ config["GOOGLE_TAG_MANAGER_ID"] }}'); @@ -102,7 +102,7 @@ - diff --git a/pmg/utils.py b/pmg/utils.py index 9b50f7c1..627797dd 100644 --- a/pmg/utils.py +++ b/pmg/utils.py @@ -32,7 +32,7 @@ def track_pageview(path=None, ignore_bots=True): """ User Google Analytics to track this pageview. """ from pmg import app - ga_id = app.config.get("GOOGLE_ANALYTICS_ID") + ga_id = app.config["GOOGLE_ANALYTICS_ID"] if not ga_id: return False