Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Nehalen dtrmm #1563

Closed
andreasnoack opened this issue May 17, 2018 · 4 comments
Closed

Issue with Nehalen dtrmm #1563

andreasnoack opened this issue May 17, 2018 · 4 comments

Comments

@andreasnoack
Copy link
Contributor

From Julia linked to the 0.3.0 prerelease, I'm getting

julia> BLAS.trmm!('L', 'U', 'N', 'N', Float64(1), ones(Float64,3,3), ones(Float64,3,3))
3×3 Array{Float64,2}:
 3.0           3.0           3.0
 2.0           2.0           2.0
 6.92492e-310  6.92492e-310  6.92492e-310

It gives the correct result for s, c, and z or when setting OPENBLAS_CORETYPE=penryn.

@andreasnoack andreasnoack mentioned this issue May 17, 2018
2 tasks
@martin-frbg
Copy link
Collaborator

Would you happen to know from previous Julia tests if this is a regression ? The only difference between 0.2.20 and 0.3.0 that I am aware off is that I switched KERNEL.NEHALEM to use the generic implementation of dswap (which I think does not affect trmm). I did notice trmm problems (lapack test failures) on some 32bit platforms including mips but my impression so far is that they are not new.

@brada4
Copy link
Contributor

brada4 commented May 17, 2018

Does CONSISTENT_FPCSR=1 build parameter change things? (number looks like in denormals to the ankles)

@martin-frbg
Copy link
Collaborator

Bisecting now as I see it worked with ab87ee6 from late october.

@martin-frbg
Copy link
Collaborator

martin-frbg commented May 17, 2018

git bisect says e5cc3d7 is the first bad commit - this is "core.IdenticalExpr clang501 checker" from the "code cleanup" PR #1419 of january 19 which brought the simplification of a lengthy block of conditionals in the generic trmm_ltcopy and trmm_utcopy routines. Sorry (again) for not noticing the problems with this PR when I merged it, I will return the affected files to their earlier state now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants