Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tab configuration error message in Mage_Adminhtml_Block_Widget_Tabs #3637

Merged
merged 1 commit into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function addTab($tabId, $tab)
}

if (!($this->_tabs[$tabId] instanceof Mage_Adminhtml_Block_Widget_Tab_Interface)) {
throw new Exception(Mage::helper('adminhtml')->__('Wrong tab configuration.'));
throw new Exception(Mage::helper('adminhtml')->__('Wrong tab configuration for %s %s.', $tabId, $tab));
}
} else {
throw new Exception(Mage::helper('adminhtml')->__('Wrong tab configuration.'));
Expand Down
1 change: 1 addition & 0 deletions app/locale/en_US/Mage_Adminhtml.csv
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,7 @@
"Wrong newsletter template.","Wrong newsletter template."
"Wrong quote item.","Wrong quote item."
"Wrong tab configuration.","Wrong tab configuration."
"Wrong tab configuration for %s %s.","Wrong tab configuration for %s %s."
"Wrong tag was specified.","Wrong tag was specified."
"Wrong transaction ID specified.","Wrong transaction ID specified."
"XML","XML"
Expand Down