Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Error in frontend with improper request params #3925

Closed
ioweb-gr opened this issue Apr 5, 2024 · 4 comments · Fixed by #3926
Closed

PHP Error in frontend with improper request params #3925

ioweb-gr opened this issue Apr 5, 2024 · 4 comments · Fixed by #3926

Comments

@ioweb-gr
Copy link
Contributor

ioweb-gr commented Apr 5, 2024

Preconditions (*)

  1. Openmage 20.5.0

Steps to reproduce (*)

  1. Visit url https://demo.openmage.org/men/shirts.html?occasion=30,31 and check the php error

Expected result (*)

  1. The page opens and the filter is not applied but do not show error to the user.

Actual result (*)

  1. PHP Error
 Uncaught TypeError: strlen(): Argument #1 ($string) must be of type string, array given in /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Catalog/Model/Layer/Filter/Attribute.php:81\nStack trace:\n#0 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Catalog/Block/Layer/Filter/Abstract.php(81): Mage_Catalog_Model_Layer_Filter_Attribute->apply()\n#1 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Catalog/Block/Layer/Filter/Abstract.php(63): Mage_Catalog_Block_Layer_Filter_Abstract->_initFilter()\n#2 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Catalog/Block/Layer/View.php(125): Mage_Catalog_Block_Layer_Filter_Abstract->init()\n#3 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Core/Block/Abstract.php(299): Mage_Catalog_Block_Layer_View->_prepareLayout()\n#4 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Core/Model/Layout.php(474): Mage_Core_Block_Abstract->setLayout()\n#5 /var/www/vhosts/example.gr/httpdocs/app/code/core/Mage/Core/M.
@fballiano
Copy link
Contributor

I've created #3926 to fix this, please review the PR when you can

@ioweb-gr
Copy link
Contributor Author

ioweb-gr commented Apr 5, 2024

Thanks I'll be able to test it tomorrow

@sreichel
Copy link
Contributor

sreichel commented Feb 4, 2025

@all-contributors add @ioweb-gr bug

Copy link
Contributor

@sreichel

I've put up a pull request to add @ioweb-gr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants