Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rebase instead of merge for PRs #385

Closed
edannenberg opened this issue Nov 21, 2017 · 4 comments
Closed

Use rebase instead of merge for PRs #385

edannenberg opened this issue Nov 21, 2017 · 4 comments

Comments

@edannenberg
Copy link
Contributor

I find the current git history really hard to work with due to all the pointless merge commits. Picasso would have been proud. ;) Ideally the history for any given branch should be a straight line.

Proposal: Come up with a git strategy that prevents those issues in the future and gives users a clean view of what changed.

For starters:

  • PR should always get rebased so a FF merge can be used which eliminates those pesky merge commits, the Github interface has options for that so the time impact for maintainers should be minimal
  • Strict rules regarding commit messages
    • Should be rather verbose for fixes
    • Maybe use starting tags like [fix] or [bug], etc, so the git history can be scraped to generate a, sorely needed, changelog for this repo

If a middle ground for this can be found I can offer to unfuck the current history of the 1.9.3.x branch.

@blopa
Copy link
Contributor

blopa commented Nov 21, 2017

+1 for rebasing

@tomekjordan
Copy link

tomekjordan commented Nov 21, 2017

I dream about Changelog file... like Algolia, Nosto and zillions github projects provide

@tmotyl
Copy link
Contributor

tmotyl commented Nov 22, 2017

I'm all for it. But please also see discussion here #155

@edannenberg
Copy link
Contributor Author

@tmotyl I see, this can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants