Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin theme issue (overlapping menu items) #3394

Closed
seifer7 opened this issue Jul 20, 2023 · 7 comments · Fixed by #3396
Closed

Admin theme issue (overlapping menu items) #3394

seifer7 opened this issue Jul 20, 2023 · 7 comments · Fixed by #3396

Comments

@seifer7
Copy link
Contributor

seifer7 commented Jul 20, 2023

Preconditions (*)

  1. OpenMage version 20.0.20

Steps to reproduce (*)

  1. Have enough top-level menu items to wrapped menu to more than 1 line
  2. Open a page from a menu on the bottom row of menu items
  3. Notice that the selected menu is now highlighted
  4. Hover over a menu item ABOVE the highlighted menu

Expected result (*)

  1. On step 4 the hover menu displayed should appear ON TOP of the other menu items
    image

Actual result (*)

  1. On step 4 the hover menu is displayed BELOW the highlighted menu item (current page)
    image
@seifer7 seifer7 added the bug label Jul 20, 2023
@seifer7
Copy link
Contributor Author

seifer7 commented Jul 20, 2023

Fix should be as simple as removing the z-index from #nav li.active

&.active {
z-index: 1000;
margin-left: -1px;
color: $white;
font-weight: bold;

As far as I can tell, that z-index was only added to fix li separators from appearing on-top of the active menu item in the legacy admin skin. The separators are not used in the new theme.

@fballiano
Copy link
Contributor

@seifer7 thank you for this report, do you want to open a PR or you want me to do it?

@elidrissidev
Copy link
Member

This issue is also happening with the default admin theme, so would be better to fix in both.

@seifer7
Copy link
Contributor Author

seifer7 commented Jul 20, 2023

This issue is also happening with the default admin theme, so would be better to fix in both.

Oh, thank you. I will have a look at it soon.

@addison74
Copy link
Contributor

addison74 commented Jul 20, 2023

Please take in consideration changing the SCSS files too and generate the CSS for both backends.

@sreichel
Copy link
Contributor

sreichel commented Feb 4, 2025

@all-contributors add @seifer7 bug

Copy link
Contributor

@sreichel

I've put up a pull request to add @seifer7! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants