Add Access logs support to MpTelemetry-2.0 #30850

tonyreigns · 2025-02-24T16:07:58Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

This is a beta guarded feature targeting 25004-beta.

Epic: #29228

tonyreigns · 2025-02-24T16:16:39Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-02-24T16:23:52Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

dmuelle

ID review

...erty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties

...sources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

LibbyBot · 2025-02-24T23:15:01Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ykXX8PL8Ee-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

tonyreigns · 2025-02-25T00:28:08Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-02-25T00:35:18Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

LibbyBot · 2025-02-25T09:07:02Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_fk9Y9_NPEe-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

tonyreigns · 2025-02-25T14:01:46Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-02-25T14:09:48Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

...liberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/metatype/metatype.xml

...penliberty/microprofile/telemetry20/logging/internal/MpTelemetryAccessEventMappingUtils.java

...src/io/openliberty/microprofile/telemetry20/logging/internal/MpTelemetryLogMappingUtils.java

...sources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

tonyreigns · 2025-02-25T21:54:58Z

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-02-25T22:02:12Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

6 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

LibbyBot · 2025-02-26T01:54:02Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_K4ZvQPPcEe-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

tonyreigns · 2025-02-26T03:45:18Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-02-26T03:52:45Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

LibbyBot · 2025-02-26T12:27:00Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_mEdI4fQ0Ee-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

...sources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

...microprofile.telemetry.2.0.logging.internal_2_fat/publish/servers/TelemetryAccess/server.xml

.../fat/src/io/openliberty/microprofile/telemetry/logging/internal_fat/TelemetryAccessTest.java

dmuelle

LGTM, thanks

LibbyBot · 2025-02-26T17:07:02Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_twEfAfRbEe-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

tonyreigns · 2025-02-26T18:33:20Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

tonyreigns · 2025-02-26T18:34:51Z

#libby (view Open Liberty Delivery Requirements Verification - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/logging/source/AccessLogSource.java

...src/io/openliberty/microprofile/telemetry20/logging/internal/MpTelemetryLogMappingUtils.java

.../fat/src/io/openliberty/microprofile/telemetry/logging/internal_fat/TelemetryAccessTest.java

pgunapal · 2025-02-26T18:36:05Z

...openliberty.microprofile.telemetry.2.0.logging.internal_2_fat/publish/files/accessServer.xml

@@ -0,0 +1,24 @@
+<!--
+    Copyright (c) 2024, 2025 IBM Corporation and others.


doesn't need 2024

pgunapal · 2025-02-26T18:36:41Z

...microprofile.telemetry.2.0.logging.internal_2_fat/publish/servers/TelemetryAccess/server.xml

@@ -0,0 +1,22 @@
+<!--
+    Copyright (c) 2024, 2025 IBM Corporation and others.


doesnt need 2024

LibbyBot · 2025-02-26T18:41:59Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

LibbyBot · 2025-02-26T18:42:38Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

7 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
13 product code files were changed.
Please describe in a separate comment how you tested your changes.
1 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops
2 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/io.openliberty.microprofile.telemetry.2.0.logging.internal/resources/OSGI-INF/l10n/metatype.properties
- dev/io.openliberty.microprofile.telemetry.internal.common/resources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops

pgunapal

LGTM - Have a follow-on PR to address review comments.

LibbyBot · 2025-02-27T08:12:01Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_I3GZcPTaEe-5mo24eL2W6g

Target locations of links might be accessible only to IBM employees.

tonyreigns added 7 commits February 24, 2025 10:31

Initial access logs drop

5b763fe

Initial drop of mpTelemetry Access log support

819e6cb

Adding Telemetry access log setters

d2bbde8

Adding server.xml attribute

a8471a6

Telemetry Logging related changes

aff626b

Creating ListFieldAdder interface

b434970

Adding beta guards for Telemetry access logs

6c411b8

tonyreigns self-assigned this Feb 24, 2025

tonyreigns changed the title ~~Telemetry access logs~~ Add Access logs support to MpTelemetry-2.0 Feb 24, 2025

Updating copyright years

8d80dad

Minor fixes

958b7f9

dmuelle requested changes Feb 24, 2025

View reviewed changes

dmuelle added the ID waiting on development label Feb 24, 2025

LibbyBot added the CLA Signed label Feb 24, 2025

ID update

cd4b78b

Fixing metatype attribute and cleanup

c2f8014

tonyreigns force-pushed the telemetryAccessLogs branch from 4507b5c to c2f8014 Compare February 25, 2025 14:23

tonyreigns requested a review from pgunapal February 25, 2025 14:24

pgunapal requested changes Feb 25, 2025

View reviewed changes

tonyreigns force-pushed the telemetryAccessLogs branch from b34a22a to 3e4836c Compare February 25, 2025 18:20

PR review fixes

e62b690

tonyreigns force-pushed the telemetryAccessLogs branch from 3e4836c to e62b690 Compare February 25, 2025 19:00

tonyreigns requested a review from dmuelle February 25, 2025 22:37

tonyreigns force-pushed the telemetryAccessLogs branch from a81f39d to 6211162 Compare February 25, 2025 22:45

tonyreigns requested a review from pgunapal February 25, 2025 22:49

Adding basic FAT test

d4a3b09

tonyreigns force-pushed the telemetryAccessLogs branch from 6211162 to d4a3b09 Compare February 26, 2025 03:44

dmuelle reviewed Feb 26, 2025

View reviewed changes

...sources/io/openliberty/microprofile/telemetry/internal/common/resources/MPTelemetry.nlsprops Show resolved Hide resolved

pgunapal requested changes Feb 26, 2025

View reviewed changes

...microprofile.telemetry.2.0.logging.internal_2_fat/publish/servers/TelemetryAccess/server.xml Outdated Show resolved Hide resolved

.../fat/src/io/openliberty/microprofile/telemetry/logging/internal_fat/TelemetryAccessTest.java Outdated Show resolved Hide resolved

dmuelle previously approved these changes Feb 26, 2025

View reviewed changes

dmuelle added ID reviewed and removed ID waiting on development labels Feb 26, 2025

tonyreigns dismissed dmuelle’s stale review via 01fd5c8 February 26, 2025 18:18

Cleaning FAT and resolving OTel message body

857eace

tonyreigns force-pushed the telemetryAccessLogs branch from 01fd5c8 to 857eace Compare February 26, 2025 18:20

tonyreigns requested a review from pgunapal February 26, 2025 18:34

pgunapal requested changes Feb 26, 2025

View reviewed changes

tonyreigns requested a review from pgunapal February 26, 2025 20:47

pgunapal approved these changes Feb 26, 2025

View reviewed changes

tonyreigns merged commit 83b3299 into OpenLiberty:integration Feb 27, 2025
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Access logs support to MpTelemetry-2.0 #30850

Add Access logs support to MpTelemetry-2.0 #30850

tonyreigns commented Feb 24, 2025 •

edited by pgunapal

Loading

tonyreigns commented Feb 24, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Feb 24, 2025

dmuelle left a comment

LibbyBot commented Feb 24, 2025

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Feb 25, 2025

LibbyBot commented Feb 25, 2025

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Feb 25, 2025

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Feb 25, 2025

LibbyBot commented Feb 26, 2025

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Feb 26, 2025

LibbyBot commented Feb 26, 2025

dmuelle left a comment

LibbyBot commented Feb 26, 2025

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading

pgunapal Feb 26, 2025

pgunapal Feb 26, 2025

LibbyBot commented Feb 26, 2025

LibbyBot commented Feb 26, 2025

pgunapal left a comment

LibbyBot commented Feb 27, 2025

		@@ -0,0 +1,24 @@
		<!--
		Copyright (c) 2024, 2025 IBM Corporation and others.

		@@ -0,0 +1,22 @@
		<!--
		Copyright (c) 2024, 2025 IBM Corporation and others.

Add Access logs support to MpTelemetry-2.0 #30850

Add Access logs support to MpTelemetry-2.0 #30850

Conversation

tonyreigns commented Feb 24, 2025 • edited by pgunapal Loading

tonyreigns commented Feb 24, 2025 • edited by LibbyBot Loading

LibbyBot commented Feb 24, 2025

Code analysis and actions

dmuelle left a comment

Choose a reason for hiding this comment

LibbyBot commented Feb 24, 2025

tonyreigns commented Feb 25, 2025 • edited by LibbyBot Loading

LibbyBot commented Feb 25, 2025

Code analysis and actions

LibbyBot commented Feb 25, 2025

tonyreigns commented Feb 25, 2025 • edited by LibbyBot Loading

LibbyBot commented Feb 25, 2025

Code analysis and actions

tonyreigns commented Feb 25, 2025 • edited by LibbyBot Loading

LibbyBot commented Feb 25, 2025

Code analysis and actions

LibbyBot commented Feb 26, 2025

tonyreigns commented Feb 26, 2025 • edited by LibbyBot Loading

LibbyBot commented Feb 26, 2025

Code analysis and actions

LibbyBot commented Feb 26, 2025

dmuelle left a comment

Choose a reason for hiding this comment

LibbyBot commented Feb 26, 2025

tonyreigns commented Feb 26, 2025 • edited by LibbyBot Loading

tonyreigns commented Feb 26, 2025 • edited by LibbyBot Loading

pgunapal Feb 26, 2025

Choose a reason for hiding this comment

pgunapal Feb 26, 2025

Choose a reason for hiding this comment

LibbyBot commented Feb 26, 2025

Code analysis and actions

LibbyBot commented Feb 26, 2025

Code analysis and actions

pgunapal left a comment

Choose a reason for hiding this comment

LibbyBot commented Feb 27, 2025

tonyreigns commented Feb 24, 2025 •

edited by pgunapal

Loading

tonyreigns commented Feb 24, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 25, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading

tonyreigns commented Feb 26, 2025 •

edited by LibbyBot

Loading