Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge staging to prod - Change server to runtime or instance #149

Merged
merged 2 commits into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ mvn liberty:run
```
endif::[]

After you see the following message, your application server is ready:
After you see the following message, your application Liberty instance is ready:

[role="no_copy"]
----
Expand All @@ -97,7 +97,7 @@ Next, point your browser to the http://localhost:9080[http://localhost:9080^] we
endif::[]

ifdef::cloud-hosted[]
When the server is running, select **Terminal** > **New Terminal** from the menu of the IDE to open another command-line session. Open your browser and check out the application by going to the URL that the following command returns:
When the Liberty instance is running, select **Terminal** > **New Terminal** from the menu of the IDE to open another command-line session. Open your browser and check out the application by going to the URL that the following command returns:
```bash
echo http://${USERNAME}-9080.$(echo $TOOL_DOMAIN | sed 's/\.labs\./.proxy./g')
```
Expand Down Expand Up @@ -134,7 +134,7 @@ After you start the service, you can find your artist JSON at the http://localho
endif::[]

ifdef::cloud-hosted[]
After the server is started, run the following curl command to view your artist JSON.
After the Liberty instance is started, run the following curl command to view your artist JSON.
```bash
curl -s http://localhost:9080/artists | jq
```
Expand Down Expand Up @@ -346,7 +346,7 @@ To run the default test, you can add the [hotspot=node-tests file=1]`testing` co

Although the React application in this guide is simple, when you build more complex React applications, testing becomes a crucial part of your development lifecycle. If you need to write application-oriented test cases, follow the official https://reactjs.org/docs/testing.html[React testing documentation^].

When you are done checking the application root, exit dev mode by pressing CTRL+C in the shell session where you ran the server, or by typing `q` and then pressing the `enter/return` key.
When you are done checking the application root, exit dev mode by pressing CTRL+C in the shell session where you ran the Liberty, or by typing `q` and then pressing the `enter/return` key.

== Great work! You're done!

Expand Down
2 changes: 1 addition & 1 deletion finish/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<plugin>
<groupId>io.openliberty.tools</groupId>
<artifactId>liberty-maven-plugin</artifactId>
<version>3.7.1</version>
<version>3.8.2</version>
</plugin>
<!-- Frontend resources -->
<!-- tag::frontend-plugin[] -->
Expand Down
24 changes: 12 additions & 12 deletions finish/src/main/frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion start/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<plugin>
<groupId>io.openliberty.tools</groupId>
<artifactId>liberty-maven-plugin</artifactId>
<version>3.7.1</version>
<version>3.8.2</version>
</plugin>
<!-- Frontend resources -->
<plugin>
Expand Down