Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 4.2 - calculating the p-values - - visualise() #261

Open
fernando-pierucci-alves opened this issue Aug 10, 2024 · 2 comments
Open

Comments

@fernando-pierucci-alves

Contact Details

No response

Bug

It seems an update to Infer package makes the following code obsolete. If so, the tutorial is much worth an update.

gender_discrimination_perm |>
visualise(obs_stat = diff_orig, direction = "greater")

In Rstudio (linux), the following comes up:

"WARNING message: The arguments c("obs_stat", "direction") are deprecated in visualize() and will be ignored. They should now be passed to one of shade_p_value() or shade_confidence_interval(). "

Reproducible Example

gender_discrimination_perm |>
visualise(obs_stat = diff_orig, direction = "greater")

Expected Behavior

Not sure what output would be.

Session Info

No response

Additional context

No response

@mamcisaac
Copy link
Contributor

mamcisaac commented Aug 12, 2024

It looks like arguments were relocated from visualize() to shade_p_value() and shade_confidence_interval() in version 1.0.0 of the infer package:

Move forward with a number of planned deprecations. Namely, the GENERATION_TYPES object is now fully deprecated, and arguments that were relocated from visualize() to shade_p_value() and shade_confidence_interval() are now fully deprecated in visualize(). If supplied a deprecated argument, visualize() will warn the user and ignore the argument.
-- https://infer.tidymodels.org/news/index.html#breaking-changes-1-0-0

Any lessons and exercises using the infer package (including 04-02-lesson.Rmd) will presumably need a fairly substantial re-write, if they are introducing the old approach to coding for the visualize() package.

@fernando-pierucci-alves
Copy link
Author

My view is that it is up to the authors to decide how to proceed. Thanks for looking at this problem.
FPA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants