Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] migrating to pnpm for the monorepo setup #145

Open
DerekNonGeneric opened this issue Nov 14, 2022 · 1 comment
Open

[discussion] migrating to pnpm for the monorepo setup #145

DerekNonGeneric opened this issue Nov 14, 2022 · 1 comment

Comments

@DerekNonGeneric
Copy link
Member

DerekNonGeneric commented Nov 14, 2022

We currently have a couple of deps that we need to either replace or bundle w/ the deployed package (thanks to socket for flagging them as trivial):

We also have a problem of the npm lockfile version changing from 2 to 3 in npm@9

Does this mean that we should switch to either pnpm for their lockfile at this point, or maybe Yarn?

I don't really mind either way, but the problematic lockfile bump is going to be something to watch out for:

The Snyk check was failing those PRs as the lockfile being inconsistent w/ the deps(-dev) that are listed in our package.json — we can't have this as being flagged by Snyk (unacceptable).

/cc @shellscape

@DerekNonGeneric
Copy link
Member Author

Here is something worth reading regarding this issue: https://nx.dev/concepts/integrated-vs-package-based

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant