Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read more/Share buttons on news items appear inconsistently #21

Closed
mishari opened this issue Mar 10, 2015 · 3 comments
Closed

Read more/Share buttons on news items appear inconsistently #21

mishari opened this issue Mar 10, 2015 · 3 comments

Comments

@mishari
Copy link

mishari commented Mar 10, 2015

Issue by DBishton
Thursday Mar 05, 2015 at 12:09 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT
Originally opened as oeco#40

Please see screenshot below. What causes this discrepancy?

image
@Huyeng
Copy link
Collaborator

Huyeng commented Mar 25, 2015

For those news articles which have Geo location, the share buttons will be appeared, for those no geo location, only "Read More".
Should me take the share button off to make it be consistent?

@DBishton
Copy link

@Huyeng Nice work. I think it should stay as is, it's good functionality to have. As all news now being produced will be geo-located, the inconsistent presentation shouldn't be a problem. Thanks!

@Huyeng
Copy link
Collaborator

Huyeng commented Mar 25, 2015

Ok. If so, I think the issue can close.

@Huyeng Huyeng closed this as completed Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mishari @DBishton @Huyeng