[BUG][TYPESCRIPT-ANGULAR] client generated README with apiModulePrefix

[sorohan]

Description

When specifying the apiModulePrefix the generated README still says to import ApiModule.

If you specify a prefix (eg PetStore) the generated README should say to import PetStoreApiModule.

openapi-generator version

4.3.0 (also checked on master)

OpenAPI declaration file content or url

The petstore YAML is sufficient to reproduce it.

Command line used for generation

You can generate using the samples, as the generated code contains the bug.

You can use the typescript-angular-with-prefixed-module-name-v8 sample:

sh bin/generate-samples.sh bin/configs/typescript-angular-with-prefixed-module-name-v8.yaml

Steps to reproduce

1. clone the openapi-generator repo
2. setup the repo (mvn clean package)
3. generate the sample with prefixed module: sh bin/generate-samples.sh bin/configs/typescript-angular-with-prefixed-module-name-v8.yaml

Expected result:
Sample readme (samples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-prefixed-module-name/README.md) should contain PetStoreApiModule.

Actual result:
Sample readme contains ApiModule.

See the general usage generated for the sample.

Suggest a fix/enhancement

I have a branch with the fix, and I can make a PR if you agree. See: https://github.com/OpenAPITools/openapi-generator/compare/master...sorohan:bugfix/typescript-angular-docs-with-module-prefix?expand=1

The thing I'm least sure about is updating the section on "Using multiple OpenAPI files / APIs / ApiModules". The advice given currently is to use:

import { ApiModule as OtherApiModule } from 'my-other-api-path';

But I think it would be better to just recommend people to use the apiModulePrefix option, as I assume that's what it's there for.

[macjohnny]

@sorohan a PR would be appreciated.
however, this line needs to be changed
https://github.com/sorohan/openapi-generator/blob/54d2f056f3ddd56847e969407f2d23c22dd19f75/modules/openapi-generator/src/main/resources/typescript-angular/README.mustache#L135

to
import { {{apiModuleClassName}} as OtherApiModule } from 'my-other-api-path';

[sorohan]

No, that's not quite right, and that's why this section is a bit strange. Then you would have:

import { PetStoreModule } from 'my-api-path';
import { PetStoreModule } from 'my-other-api-path';

With the PR it will be

import { PetStoreModule } from 'my-api-path';
import { OtherApiModule } from 'my-other-api-path';

or

import { ApiModule } from 'my-api-path';
import { OtherApiModule } from 'my-other-api-path';

With the implication that you used Other as the prefix for the other module.

But I'm open for suggestions on how to make that more clear :)

Edit: I've opened the PR and tried to improve the wording, so we can discuss it there.

[macjohnny]

@sorohan the line in question
https://github.com/OpenAPITools/openapi-generator/blame/master/samples/client/petstore/typescript-angular-v10-provided-in-root/builds/with-npm/README.md#L136
serves as an example how to use / rename / alias api modules with the same name (e.g. if you use api packages published somewhere and you can't change/prefix the module name)