Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] client_side_validation comment is backwards #6847

Closed
3 of 6 tasks
mdavis-xyz opened this issue Jul 3, 2020 · 1 comment · Fixed by #6850
Closed
3 of 6 tasks

[BUG] client_side_validation comment is backwards #6847

mdavis-xyz opened this issue Jul 3, 2020 · 1 comment · Fixed by #6850

Comments

@mdavis-xyz
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs? here
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

In the configuration.py file after generating a python client, it says:

# Disable client side validation
self.client_side_validation = True

This makes it seem like client side validation is disabled by default.
But it's not.

The comment should be # set to False to disable client side validation, or just # Enable client side validation

openapi-generator version
openapi-generator-cli 5.0.0-SNAPSHOT
  commit : 068ad02
  built  : 2020-07-02T17:04:18Z
  source : https://github.com/openapitools/openapi-generator
  docs   : https://openapi-generator.tech/
Command line used for generation
docker run --rm \
    -v $PWD:/local \
    openapitools/openapi-generator-cli \
    generate \
    -i /local/repo/direct-plant-control.yaml \
    -g python \
    -o /local/out/python \
    --package-name dispatch
Steps to reproduce
Related issues/PRs

@jonashaag added a comment to the PR by @wing328 that introduced this issue here

Suggest a fix

The comment should be # set to False to disable client side validation, or just # Enable client side validation

@auto-labeler
Copy link

auto-labeler bot commented Jul 3, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant