Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 end of life #6522

Closed
ybelenko opened this issue Jun 2, 2020 · 5 comments
Closed

PHP 7.1 end of life #6522

ybelenko opened this issue Jun 2, 2020 · 5 comments

Comments

@ybelenko
Copy link
Contributor

ybelenko commented Jun 2, 2020

PHP 7.1 reached end of life at 1 Dec 2019

End of life - A release that is no longer supported. Users of this release should upgrade as soon as possible, as they may be exposed to unpatched security vulnerabilities.

PHP: Supported Versions:

  • 7.2 until 30 Nov 2020
  • 7.3 until 6 Dec 2021
  • 7.4 until 28 Nov 2022

It seems that we need to change minimum PHP version to 7.2 in all php generators.

Current Requirements:

Generator PHP version
php client >= 7.2
Laravel server >= 7.2.5
Lumen server >= 7.2.5
Slim4 server >= 7.2
Symfony server >= 7.1.3
Ze-ph server >= 7.2

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

@ybelenko
Copy link
Contributor Author

@Articus I've seen your good work at #1902

Can you help with upgrade php-ze-ph server?
I would do it myself, but there are no unit tests in php-ze-ph generator.
We need to set PHP version to ^7.2 in composer.json:

and also here

Packagist says that zendframework/zend-expressive package and few others are abandoned. We need to replace them with suggested packages.

@Articus
Copy link
Contributor

Articus commented Jun 14, 2020

Sure, but it would be better to move zendframework/zend-expressive replacement to another issue.

It is really simple to bump minimal PHP version to 7.2 - I am like 99%-sure that everything is still working, but it will be dutiful to run tests against current minor version of PHP 7.2. Can do that before next weekend.

Replacement of zendframework/zend-expressive is way more complex problem. All packages in zendframework namespace were renamed - https://getlaminas.org/blog/2020-03-09-transferring-zf-to-laminas.html (for example, Zend Expressive is now Laminas Mezzio). So it will require:

  • php-ze-ph template update (composer.json and namespaces in PHP code)
  • php-ze-ph generator rename
  • support from PathHandler and DataTransfer which is slightly postponed (mostly because of Final Fantasy VII Remake :[ ) and I do not have ETA for that right now

@Articus
Copy link
Contributor

Articus commented Jun 21, 2020

Checked generated stub on 7.4.7 , 7.3.19 and 7.2.31 - everything works fine (manual calls of generated methods and tests for PathHandler and DataTransfer versions used in stub).

So it is safe to bump minimal PHP version to 7.2. Though technically requirement "php": "^7.1" is still correct - stub works fine on 7.1.33 too :)

@ybelenko
Copy link
Contributor Author

ybelenko commented Apr 7, 2021

7.2 until 30 Nov 2020

Now we need to switch all PHP generators to 7.3 version, my god. 🤣

@ybelenko
Copy link
Contributor Author

ybelenko commented Apr 7, 2021

Closed in favour of #9200

@ybelenko ybelenko closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants