Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Set isFreeFormObject property #1315

Open
wheezil opened this issue Oct 25, 2018 · 1 comment
Open

Enhancement: Set isFreeFormObject property #1315

wheezil opened this issue Oct 25, 2018 · 1 comment

Comments

@wheezil
Copy link
Contributor

wheezil commented Oct 25, 2018

Description

A free-form object field in a model can be hard to distinguish from other types in the mustache template. Making this an explicit property would be helpful

openapi-generator version

3.3.1

OpenAPI declaration file content or url
	"object_field": { 
		"type":"object"
	}
Command line used for generation

This does not seem to be specific to any generator, although different generators deal with "object" differently -- some consider it to be a primitive type and others do not.

Steps to reproduce

Process any OpenAPI definition file with model containing a field like above.

Related issues/PRs

none

Suggest a fix/enhancement

For free-form object fields, set an isFreeFormObject property to true. Add this property field to CodegenParameter and CodegenProperty, as a peer to isString, isPrimitiveType, etc. I am not yet clear what logic should be used to set this field.

@wing328 wing328 added this to the 3.3.3 milestone Nov 10, 2018
@wing328 wing328 modified the milestones: 3.3.3, 3.3.4 Nov 14, 2018
@wing328 wing328 modified the milestones: 3.3.4, 4.0.0 Nov 30, 2018
@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019
@wing328 wing328 modified the milestones: 4.1.1, 4.1.2 Aug 26, 2019
@wing328 wing328 modified the milestones: 4.1.2, 4.1.3 Sep 11, 2019
@wing328 wing328 modified the milestones: 4.1.3, 4.2.0 Oct 4, 2019
@wing328 wing328 removed this from the 4.2.0 milestone Oct 30, 2019
@ahmednfwela
Copy link
Contributor

@wing328 shouldn't this be closed as it was merged in #1338 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants