Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer: Confusing behavior when loading the configuration valid for the selected but not for the first sheet #1459

Closed
PavelBal opened this issue Jan 27, 2022 · 1 comment · Fixed by #1467
Assignees

Comments

@PavelBal
Copy link
Member

An excel file with two sheets - Sheet A and Sheet B with different structures. A configuration stored as xlm that is valid for Sheet B.

  • Add observed data -> Select the file.
  • Select Sheet B
  • Load configuration ->Error
PK-Sim®

The following excel columns do not exist in the current file. 
 
'Dose [unit]
Concentration (mass) [ng/ml]' 

The corresponding mappings from the configuration will be lost. Do you want to continue?

I actually first have to select "Reset configuration based on selected sheet" and then load the configuration... This is not the expected behavior. I think the "Reset configuration based on selected sheet" should be performed in background when loading a configuration.

@abdelr abdelr self-assigned this Jan 28, 2022
@abdelr
Copy link
Member

abdelr commented Jan 28, 2022

This could be a nice to have feature but we should think on the different scenarios that could arise. You are presenting the perfect situation where the format will match one of the sheets (not the first though). In contrast, there could be a situation where you have a file with all sheets with the same format and a given format is almost valid for all of them. Let us say all mappings are correct but there is one grouping by parameter in the format that does not exist in the file. Currently, the importer will inform the user, "there is a missing column, are you sure you want to proceed" and if you click yes, it will just ignore the column. Now with the new behavior, it will try to find the sheet that will match the format and since there will not be any we should decide whether to accept the best match (which we need to discuss) or inform that the format is not valid. We need to clearly define all these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants