Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DefaultPlotConfiguration class #877

Closed
IndrajeetPatil opened this issue Apr 14, 2022 · 5 comments · Fixed by #871
Closed

Create DefaultPlotConfiguration class #877

IndrajeetPatil opened this issue Apr 14, 2022 · 5 comments · Fixed by #871
Milestone
Version 11

Comments

@IndrajeetPatil
Copy link
Member

IndrajeetPatil commented Apr 14, 2022 •
edited
Loading

As discussed in #833
Related to #674
@IndrajeetPatil IndrajeetPatil mentioned this issue Apr 14, 2022
Merged
18 tasks
@PavelBal
Copy link
Member

Naming: didn't we want to check why PlotConfiguration is exported in TLF and maybe name this class PlotConfiguration?

DefaultPlotConfiguration is a bit misleading, as it is the actual configuration that the user can (and will) change.

@msevestre @Yuri05 any ideas how to name this guy?

@IndrajeetPatil
Copy link
Member Author

IndrajeetPatil commented Apr 20, 2022 •
edited
Loading

A few other alternatives if tlf needs to export PlotConfiguration:

  • CustomPlotConfiguration
  • GlobalPlotConfiguration
  • ReusablePlotConfiguration
  • GeneralPlotConfiguration

@IndrajeetPatil
Copy link
Member Author

bump

@IndrajeetPatil
Copy link
Member Author

With every passing day, GeneralPlotConfiguration grows on me. I think that'd be my choice.

@IndrajeetPatil IndrajeetPatil added this to the Version 11 milestone May 18, 2022
@IndrajeetPatil
Copy link
Member Author

I guess we are sticking with the placeholder name now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 11
Development

Successfully merging a pull request may close this issue.

Add plot configuration class and time profile plots Open-Systems-Pharmacology/OSPSuite-R
2 participants
@IndrajeetPatil @PavelBal