Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to OpenAPI 3.0 #58

Closed
m-mohr opened this issue Mar 15, 2018 · 4 comments
Closed

Switching to OpenAPI 3.0 #58

m-mohr opened this issue Mar 15, 2018 · 4 comments

Comments

@m-mohr
Copy link
Member

m-mohr commented Mar 15, 2018

Do we want to switch to OpenAPI 3.0? OpenAPI 2.0 is a limited in defining several data types (e.g. ArgSet due to missing oneOf, anyOf, ...) and doesn't support OAuth natively, for example.

I think the only reason to stick with OpenAPI 2.0 was the availability of the code generation tools. The question is: Is anybody after POC using one of the generators not available?

WWU is not using them. Is @aljacob still using it? But Java is supported in release candidate state for OpenAPI 3.0 anyway AFAIK. What about the others?

@m-mohr
Copy link
Member Author

m-mohr commented Mar 23, 2018

This issue in Swagger UI is blocking: swagger-api/swagger-ui#3437
Many examples are useless in the docs without having this solved.
The following PR may fix this: swagger-api/swagger-ui#4092

Regarding code generation there is one opinion so far from @aljacob

Since we now have a solid base for the API from what we did in 0.0.2, for me the switch is fine and I think we can live for the near future without a code generation tool.
However on the long run, it would be nice to have something again, so that it becomes easier for other people to implement their drivers for back-ends not yet foreseen in the current project. Hopefully the tools around the swagger world until then have caught up with the development and are available...

That's exactly what I thought, too. ;)

@m-mohr
Copy link
Member Author

m-mohr commented Mar 23, 2018

An alternative to Swagger UI for API spec doc generation could be ReDoc: https://github.com/Rebilly/ReDoc

@m-mohr m-mohr added this to the v0.3 milestone Mar 26, 2018
@m-mohr
Copy link
Member Author

m-mohr commented Apr 3, 2018

Changed to OpenAPI 3.0 in 0.3 branch.

@m-mohr
Copy link
Member Author

m-mohr commented Jun 21, 2018

Fixed the example issues in SwaggerUI by moving the examples from the outer examples-attribute to the schema example-attribute. Could still be a good idea to move to ReDoc for their multi-example support for programming languages. We could serve examples for all client libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant