Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths for FOLDER_ANNOTATION #29

Closed
diversit opened this issue Nov 5, 2021 · 2 comments · Fixed by #30
Closed

Support relative paths for FOLDER_ANNOTATION #29

diversit opened this issue Nov 5, 2021 · 2 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request

Comments

@diversit
Copy link

diversit commented Nov 5, 2021

Running into this issue when trying to replace the default Grafana sidecar by this one.

The Kiwigrid sidecar supports the path in the FOLDER_ANNOTATION value to be relative.
Its documentation says:

The annotation the sidecar will look for in configmaps to override the destination folder for files. 
The annotation value can be either an absolute or a relative path. Relative paths will be relative to FOLDER.

This sidecar does not seem to support relative paths:

[2021-11-05 13:03:44,649] kopf.objects         [ERROR   ] Failed to write file kubernetes/scheduler.json

I prefer to use relative paths so teams adding files via ConfigMaps don't have to be bothered with the actual path where the file is being copied. E.g. /tmp/dashboards in case of Grafana dashboards.

@OmegaVVeapon OmegaVVeapon self-assigned this Nov 5, 2021
@OmegaVVeapon OmegaVVeapon added the enhancement New feature or request label Nov 5, 2021
@OmegaVVeapon
Copy link
Owner

Fair request, should be fairly trivial to add.

@OmegaVVeapon
Copy link
Owner

Fix present in the latest release 1.4.0.

Thanks for the opening the issue @diversit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants