Headphones: Albums added as None #1184
Comments
|
Hi! |
|
Thanks @smcpeck. Pardon my ignorance in these matters but does this mean I can pull down the latest code from git and this fix is included? Thanks in advance. |
|
@almontef - It hasn't been merged into actual dev or EAP branch yet. If you're really itching for it, you could grab the build from my personal fork and upgrade manually. It is basically the latest EAP + this change. https://ci.appveyor.com/api/buildjobs/e9c5769a33x33n20/artifacts/Ombi.zip |
|
In EAP now. |
|
Thanks!!! I'll pull down your fork until it is merged. As this is my first time updating, I was wondering what files I need to keep to preserve my configuration and previous requests? Or will I have to start from the beginning again? Not a big deal if I do, but would rather save myself from having to reconfigure if I could avoid it. Thanks in advance. |
|
If you set your |
|
This is now in EAP. |
|
Great, the EAP fixed the issue. Not sure if this should be logged as a separate issue, but I noticed that when a album is requested, it takes a while to process (headphones side) and the request in Ombi generates an error (request failed). However, the request does get logged as successful in Ombi and the album gets searched and snatched in headphones. I am by no means a coder, but it could be that since headphones is taking so long to process the request Ombi times out thinking it must have failed when indeed it has not. Maybe increasing how long Ombi waits to deem the request failed would workaround the longer processing time of headphones when a request is made. Thanks in advance for any ideas or comments. |
|
@almontef Can you create a new issue and provide Ombi logs that shows the error? |
|
I will open up a separate issue for the timeout stuff thanks. I thought this original issue resolved itself but when I tried requesting an album, I see the same issue with an album getting placed on the wanted page with none for all fields. I am running 2.1.1469 of Ombi now. Here are the logs from the latest album request. Headphones log:***************** Ombi log:****************************** System.Xml.XmlException: '&' is an unexpected token. The expected token is ';'. Line 1, position 246. at System.Xml.XmlTextReaderImpl.Throw(Exception e) at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args) at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(String expectedToken1, String expectedToken2) at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(Int32 pos, String expectedToken1, String expectedToken2) at System.Xml.XmlTextReaderImpl.HandleEntityReference(Boolean isInAttributeValue, EntityExpandType expandType, Int32& charRefEndPos) at System.Xml.XmlTextReaderImpl.ParseText(Int32& startPos, Int32& endPos, Int32& outOrChars) at System.Xml.XmlTextReaderImpl.FinishPartialValue() at System.Xml.XmlTextReaderImpl.get_Value() at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r) at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r, LoadOptions o) at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options) at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options) at RestSharp.Deserializers.XmlDeserializer.Deserialize[T](IRestResponse response) at RestSharp.RestClient.Deserialize[T](IRestRequest request, IRestResponse raw) Ombi.Api.ApiRequest Error 2/26/2017 4:32:03 PM |
|
What version of Headphones are you on? I'll poke around a bit more tonight and try to reproduce this locally and get some better error handling around things. |
|
Thanks @smcpeck the headphones log says I am up to date and the footer on web interface says: version: a0fa658956d82c59f5336e38cfd444c96728faa4 |
|
@almontef I have a pull request [ #1199 ] out there that fixes this once & for all. I suspect that Jamie will merge it into EAP at some point in the morning. Album requests for new artists take a while because HeadPhones pulls down a bunch of album information for the artists before notifying us that the artist is available. Adding an album for an artist who already exists in your library is just as fast as requesting movies and TV shows. |
|
The Pull request has been merged into the EAP branch. Can you upgrade to the last EAP branch and check it out? |
|
So I went ahead and updated to the EAP, so now running Ombi 2.1.1482. When I request an album, it does come back much quicker than before. However, I still see the same end results in that albums are getting added as "None" within HeadPhones. The Ombi logs now show a different error when I recreate: Analytics tracking failed Ombi.Helpers.Analytics.Analytics Error 3/1/2017 12:39:26 PM The Headphones log show the following: 2017-03-01 12:40:47 ERROR Last.FM returned an error: Album not found Note the message in the headphones logs about the item already existing in the database. I deleted the headphones DB and just kept my settings, but I still get the same messages no matter what I add through Ombi and the end result is a item on the wanted list with "None" for all the fields. I am running headphones Version: a0fa658956d82c59f5336e38cfd444c96728faa4. If there is anything else I could provide please let me know. |
|
@almontef Are you sure there are no other "None - None" albums left hanging around? I had to go into HP, ignore all of those, and then I deleted them so they would stop getting triggered by HP. It looks, to me, like HP piggybacks off of If you look in the log you posted, it looks like that is happening here: The "searching for wanted albums" thing makes me think this isn't related to the specific album request you sent via Ombi. |
|
@smcpeck I thought that removing the HP db should have removed them but appears not to be the case. Right now, I got 5 of these "None - None" albums setting in the "Wanted Albums" view from my Ombi tests. I can select them and choose ignore, which removes them from the wanted list, but how do I actually delete them? I don't see an option to delete them from the drop-down menu. As long as I can keep my configuration, I am happy to blow away anything within HP that will reset me back to a "clean" state. I thought only the headphones.db would need to be deleted but it appears that maybe there is album information stored somewhere else. Thanks for all your help with this! |
|
The HP interface leaves some things to be desired for album deletion. If you go to "manage albums" and then select your ignored albums (now that you moved them there), you can then click into each album and there is a delete button available from the view of the individual album. |
|
@smcpeck it seems that users are reporting that when searching for an album they are just getting a spinning circle now, any idea why? |
|
@tidusjar If the artist does not exist in HP yet, it will take about 10 seconds for that happen. If it is an existing artist, it should add quickly like movies and tv shows do. |
|
I went ahead and removed all the artist and albums since this is a pretty new install. Nothing shows up in the wanted list, etc. I then went ahead and requested another search from Ombi for a specific album and it basically triggered a search for all albums by the artist. In managed albums I see 10 entries. One of them is the album I requested with a status of skipped. Another 7 are legit albums which show skipped as I would expect, but then the last two are again "none - none" with one of them showing as wanted. Same string of messages in HP logs: Note the object ID is the previous one I posted so even though I deleted both the album and artist this ID is being referenced elsewhere. Some questions or things to consider based on this run: Why is it searching for multiple albums? Why is it placing the album (the one with none - none) as wanted but the actual album as skipped? Besides deleting the headphones.db is there anywhere else where album references may reside? |
|
Thanks for this. I will take this info and look at some more things. Currently, we add the artist first. On the HP side, it queries for everything about the artist -- that's why it loads all albums. Once that is done, we queue the album up. The issue in your specific use case is that the album you added from Ombi is a "2012 Digital Remaster" version of the album. HP doesn't grab all the alternate releases for every album when loading up information about an artist. So this album didn't exist for HP and resulted in a "None - None." Situation. Honestly, this really feels like an HP issue. I may try to go fix the issue on their end instead of working around it in Ombi. |
|
I too think that it seems more like an HP issue. I'll keep using HP natively for now, but if you need me to test anything on HP or Ombi going forward, do let me know. Thanks again for all your efforts on this issue. |
|
I am still having this issue running ombi Version: 2.1.1527 and HP Version: debc65db5de0ba0cea9f67381c7a7732ddc7d70b. Anytime I request an album it shows listed in HP wanted as "None". Is there a way to fix this? |
|
Nope, its a hp issue and not a Ombi issue. |
|
Don't know what's being passed but the |
|
@smcpeck Do you have time to at this one? |
|
I have the same issue. Please can we try and sort this out between Ombi and HP. |
|
Hi @JohanPotgieter I'm very busy at the moment. But feel free to submit a pull request. |
|
Can we consider to drop hp support? |
|
@PotatoQuality it will not be in the initial release of the rewrite. If enough people request it then I'll add it back. But Headphones has been a massive pain. |
|
@tidusjar, I know :( that is why I'm asking :) |
Ombi Version:
2.1.1336
Update Branch:
Stable
Media Sever:
Plex
Media Server Version:
Not applicable
Operating System:
Windows 7 x64
Mono Version (only if your not on windows)
(Place text here)
Applicable Logs (from
/logs/directory or the Admin page):Problem Description:
When requesting an album, it says it is successful, but produces the above error in the Ombi log and searches for an album called "none - none" as shown in the Headphone log. I am left with an album in the wanted list that has none for all the fields.
Reproduction Steps:
Request an album.
The text was updated successfully, but these errors were encountered: