-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped working with version 25 #10
Comments
Hello! Thank you for letting me know of the problem. I didn't update to NC 25 yet, or even knew that it had already come out. At first it looks like I will only need to bump the supported version number, but I be able to know more when my NC instance finishes the upgrade process. I will keep this thread updated as things happen :) Thanks again for your support, |
Looks like NC25 changed more things than I thought! The pill radius options are now separated per theme instead of being in :root, and that already fixed most of the problems. There were a few other modifications as well to suit the new design, see PR #11 If there are any problems you experience with the upgrade, feel free to let me know, I will be happy to fix them. My instance is pretty modified from stock, so I don't see every problem that could arise in closer-to-stock instances. Thanks, |
Awesome, thank you. |
Hello! Thanks for clarifying the problem, working on it! ETA a few hours |
Thanks, working on that next! Already have some changes in the queue for the login screen, will push it out along with this correction. I probably forgot to add the -40px correction to the body height that's required due to the navbar on top, so that's why it looks like this. I'm on my phone though, I will be able to say more when I get back home in about 2 hours. |
Hello. Just got home. Looks like most of the problems (including the hidden chat menu in Talk) stemmed from hardcoding the content body height, which would have been fine if left to it's original setting. Pushing the update now, it will go live in about half a hour. Let me know if there are any other problems or incompatibilities with other plugins, I will be available to fix them. Thank you all for your support, |
Everything seems ok, thank you for your reactivity and your support :) |
Hello, not sure if you have had a chance to look at NC25 - only came out yesterday, but your wonderful CSS has stopped working.
I have had a quick look and all the CSS classes are still called the same so I am not sure why.
The text was updated successfully, but these errors were encountered: