Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving from tsd to typings for the type definition manager #139

Closed
gregvanl opened this issue Feb 25, 2016 · 13 comments
Closed

Consider moving from tsd to typings for the type definition manager #139

gregvanl opened this issue Feb 25, 2016 · 13 comments

Comments

@gregvanl
Copy link

TSD is being deprecated in favor of Typings (see DefinitelyTyped/tsd#269).
Currently the generator output includes a tsd.json files for typings. Typings supports typings.json.

When this is issue is fixed, please update the VS Code doc issue microsoft/vscode-docs#183 and we'll update the Office topic to use Typings.

@jthake
Copy link
Contributor

jthake commented Feb 26, 2016

Thanks for heads up on this. Yes I m aware of the TSD being deprecated aspect, there are a few deprecated libraries in here. We need to find a resource to do this and test it. Right now we are all heads down on Build 2016. As this is not a breaking change it is not urgent.

@gregvanl
Copy link
Author

@jthake Looks like TSD is really deprecated now. http://definitelytyped.org/tsd is no longer resolving to the tool.

@bogacg
Copy link

bogacg commented Jul 2, 2016

Any progress in this front?

@bogacg
Copy link

bogacg commented Jul 2, 2016

I've followed Upgrade steps as described in typings docs. Hope it doesn't break.

@josteink
Copy link

Normally I'd consider sending a PR for something like this, but the (lack of) attention other PRs are getting makes me not consider it worth the effort.

@jthake Is this repo abandoned at this point? Should the community create its own fork?

@beth-panx
Copy link
Member

Hey guys! Great feedback. I am currently working on the next version of generator-office. It is moving away from tsd and will use typings instead.

@gregvanl
Copy link
Author

gregvanl commented Dec 9, 2016

@beth-panx Would you also be the person to do a freshness pass over the Office topic oncode.visualstudio.com? The Markdown is at https://github.com/Microsoft/vscode-docs/blob/master/docs/runtimes/office.md.
VS Code is doing a freshness pass over all our docs next week and we wondered who could review the Office topic to make sure it is still accurate.

@josteink
Copy link

josteink commented Dec 9, 2016

@beth-panx actually now typing a has been deprecated in favor of the new @types NPM organization. you install types by typing:

npm install @types/libname

And that's it. No need for any additional tools .

@bogacg
Copy link

bogacg commented Dec 9, 2016

@josteink also, if are included under node_modules folder of subject library, devs using those libraries don't have to npm install @types/libname seperately, Typescript 2 understands that and so does VS Code. What I try to say is once @types are defined for current version they should also be included in main project for ease of use.

@josteink
Copy link

josteink commented Dec 9, 2016

Agreed. I was thinking in case the generator had dependent libraries.

Thinking it through though, you have 2 dimensions: consumed modules and exported modules.

Obviously both needs to be addressed.

@beth-panx
Copy link
Member

beth-panx commented Dec 12, 2016

@AndrewJByrne @slabereemsft could you take a look at the link @gregvanl provided and point us to the proper path/contact here?

@beth-panx
Copy link
Member

@josteink looks like yeoman generator hasn't made it to @types npm org yet. However, it's certainly an interesting/easy way to install types for the dependent libraries.

@bogacg how's the results when you follow the upgrade doc? Wanna send a pr if it works? 😬

@beth-panx
Copy link
Member

New release v1.0 leverages @types for both yo office itself and the generated projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants