Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aks-deployment target with --admin flag #341

Closed
andrstor opened this issue Feb 16, 2022 · 3 comments · Fixed by #819
Closed

Support for aks-deployment target with --admin flag #341

andrstor opened this issue Feb 16, 2022 · 3 comments · Fixed by #819
Labels
area/deployment-targets kind/missing-functionality Issues where a resource exists, but there is missing functionality or properties vs API/UI triage/potentially-stale Issues that are old and may have been fixed in more recent provider versions. Needs re-validating.

Comments

@andrstor
Copy link

Describe the bug
I'm not sure if this is a bug or user-error on my behalf.

I'm trying to setup a kubernetes-aks-deploymenttarget using the "Login with administrator credential setting", but i can't seem to figure out the correct terraform setup to make it work. Maybe this is not supported yet?

Steps to reproduce

resource "octopusdeploy_kubernetes_cluster_deployment_target" "tenant" {
  name                              = "${var.tenant_name}-kubernetes"
  cluster_url                       = ""
  environments                      = [local.environment_id]
  roles                             = ["Kubernetes"]
  namespace                         = var.tenant_name
  tenanted_deployment_participation = "Tenanted"
  tenants                           = [octopusdeploy_tenant.tenant.id]
  default_worker_pool_id            = "WorkerPools-41"

  endpoint {
    communication_style = "Kubernetes"
    authentication {
      admin_login                 = "true"
    }
  }
  azure_service_principal_authentication {
    account_id             = "Accounts-1"
    cluster_name           = "removed"
    cluster_resource_group = "removed"
  }
}

Succesfully creates the target, but without the setting checked.

Expected behavior
Target is created successfully with the admin setting checked.

Logs and other supporting information
No errors

Screenshots
image

Environment and versions:

  • OS: [ Linux, Windows]
  • Octopus Server Version: [e.g. 2021.3]
  • Terraform Version: [e.g. 1.0.9]
  • Octopus Terraform Provider Version: [e.g. 0.7.68]

Additional context
Add any other context about the problem here.

@johnsimons
Copy link
Contributor

This option is still missing in v0.10.3

@CJJ69
Copy link

CJJ69 commented Apr 19, 2023

and if you create the target and then manually set use Admin credentials checkbox
then we get validation error from next terraform plan

cannot unmarshal string into Go struct field KubernetesAzureAuthentication.AdminLogin of type bool

@CJJ69
Copy link

CJJ69 commented Sep 15, 2023

Octopus Terraform Provider Version: 0.12.7

Still need support for octopusdeploy_kubernetes_cluster_deployment_target with admin credentials flag

admin_login = "true" is not persisted

@mjhilton mjhilton added kind/missing-functionality Issues where a resource exists, but there is missing functionality or properties vs API/UI triage/potentially-stale Issues that are old and may have been fixed in more recent provider versions. Needs re-validating. area/deployment-targets labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment-targets kind/missing-functionality Issues where a resource exists, but there is missing functionality or properties vs API/UI triage/potentially-stale Issues that are old and may have been fixed in more recent provider versions. Needs re-validating.
Projects
None yet
4 participants