Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in DS #9

Closed
yatesn opened this issue Mar 3, 2022 · 4 comments · Fixed by ONSdigital/design-system#2713
Closed

Update dependencies in DS #9

yatesn opened this issue Mar 3, 2022 · 4 comments · Fixed by ONSdigital/design-system#2713
Assignees
@rmccar
Labels
Spike

Comments

@yatesn
Copy link
Collaborator

yatesn commented Mar 3, 2022

Required to improve security and fix bugs etc
@yatesn yatesn added the Spike label Mar 3, 2022
@yatesn
Copy link
Collaborator Author

yatesn commented Jul 22, 2022

Needs doing, but not currently a priority

@yatesn
Copy link
Collaborator Author

yatesn commented Jul 7, 2023

@rmccar may need your help on this (on a Monday), if possible?

@rmccar rmccar mentioned this issue Jul 10, 2023
Merged
@rmccar rmccar reopened this Jul 17, 2023
This was referenced Sep 21, 2023
Merged
Merged
@rmccar rmccar self-assigned this Sep 28, 2023
This was referenced Sep 28, 2023
Merged
Merged
Merged
Merged
Merged
@rmccar
Copy link

rmccar commented Sep 28, 2023

Ive now opened all the PRs related to this card. Some are still yet to merge because they are awaiting reviews. But I have now updated all dependancies for the DS including fixing all breaking changes. There were a 3 that I have decided not to update at least for now. These are:

  • lint-staged - this library has now become been converted to esm. It would mean converting the DS to esm which would be a big breaking change for all services that use it. It might be something that we want to discuss or find an alternative library.
  • chalk - same as above
  • fuse.js - this is used by the autosuggest component and is what takes queries and presents results back. Its has had some big changes to how the results are returned and formatted. It would mean a bit of a refactor to the autosuggest component that I think if we want to do we should tackle as its own investigation and piece of work

@rmccar
Copy link

rmccar commented Oct 27, 2023

All PRs merged

@rmccar rmccar closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmccar rmccar

Labels
Spike
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Node 16 and minor updates to other DS dependencies ONSdigital/design-system
3 participants
@rmccar @yatesn @emilymaylawes