Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book DAC test and create prototype for new features added since last audit for census #10

Closed
77 of 88 tasks
yatesn opened this issue Feb 2, 2022 · 3 comments
Closed
77 of 88 tasks

Comments

@yatesn
Copy link
Collaborator

yatesn commented Feb 2, 2022

Features needing an accessibility audit include:

Foundations

  • Links - DS and eQ
    • New hover style added so state didn't rely on colour change alone – thicker underline – is the change in thickness significant enough?
    • External link missing screen reader hidden notice (that opens in a new tab)
  • Highlighting - DS only
    • Any issues with focus colour clashing with similar colour used for highlighting important information?
    • Is <em> semantically the correct tag for highlighting piped answers etc?
    • Should the font-weight of an <em> be bold or left to style as italics?

Components

Patterns

  • Dates and Durations - DS only
  • Numeric values - DS only
    • Inputs with prefixed/suffixed units and hint text
      • On Voiceover for iOS, the hint text appears to interrupt the announcement of units provided by the title attribute as it reads the aria-describedby by instead.
  • Errors - eQ
    • When you select a link in the error summary panel at the top of the page, we didn't put focus on the first option in a radio/checkbox fieldset – would be good to clarify if this is acceptable.
    • Is it an issue that the error summary header is an <h2> yet placed above the page heading <h1>?
    • When page loads with an error, should the error summary panel focus state be visible? Should tabindex=-1 be removed after focus is lost?
    • Check prototype
  • Download resources - DS only
  • Extend a session - eQ
  • Send and reply to messages - RASRM
  • News - DS only
  • Question - DS and eQ
    • Legend as question title (wraps page heading in a <legend>when question and fieldset answer is the only thing on the page)
  • DS site search - DS
    • 'Search the design system' persistent across the website
@yatesn
Copy link
Collaborator Author

yatesn commented Feb 23, 2022

Gather updated requirements from Sarah Brooks (eQ) and contact craig.dunn@digitalaccessibilitycentre.org and/or cam.nicholl@digitalaccessibilitycentre.org

@jrbarnes9 jrbarnes9 transferred this issue from ONSdigital/design-system Mar 10, 2022
@jrbarnes9
Copy link

@yatesn This is now an exhaustive list of what we need testing on

@jrbarnes9 jrbarnes9 self-assigned this Mar 28, 2022
@jrbarnes9
Copy link

Building prototype for DS feature testing

@jrbarnes9 jrbarnes9 changed the title Book DAC test for new features added since last audit for census Book DAC test and create prototype for new features added since last audit for census Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants