Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and update the label checker github action #3184

Closed
rmccar opened this issue May 9, 2024 · 0 comments · Fixed by #3197 or #3203
Closed

Review and update the label checker github action #3184

rmccar opened this issue May 9, 2024 · 0 comments · Fixed by #3197 or #3203
Assignees
@rmccar
Labels
CI/CD This PR makes changes to the CI/CD process Spike Requires investigation outside BAU work

Comments

@rmccar
Copy link
Contributor

rmccar commented May 9, 2024

We seem to have adopted adding the "breaking changes" and "do not merge" labels to breaking change PRs while we wait to merge them. Currently the label checker will fail for having both those labels. We should review the label rules and decide if we want to change them
@rmccar rmccar added the Spike Requires investigation outside BAU work label May 9, 2024
@rmccar rmccar self-assigned this May 9, 2024
@rmccar rmccar mentioned this issue May 9, 2024
Merged
2 tasks
@adi-unni adi-unni added the CI/CD This PR makes changes to the CI/CD process label May 10, 2024
@rmccar rmccar reopened this May 13, 2024
@rmccar rmccar mentioned this issue May 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmccar rmccar

Labels
CI/CD This PR makes changes to the CI/CD process Spike Requires investigation outside BAU work
Projects
None yet
Milestone
No milestone
2 participants
@rmccar @adi-unni