Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove min and max HTML attributes for inputs with type set to "text" #3160

Closed
rmccar opened this issue Apr 25, 2024 · 0 comments · Fixed by #3161
Closed

Remove min and max HTML attributes for inputs with type set to "text" #3160

rmccar opened this issue Apr 25, 2024 · 0 comments · Fixed by #3161
Assignees
@rmccar
Labels
Bug Something isn't working
Milestone
Deliver new itera...

Comments

@rmccar
Copy link
Contributor

rmccar commented Apr 25, 2024

After the investigation needed for #3098 I have concluded we need to update any inputs that have the type attribute set to "text" to have the min and max attributes removed. This is because its invalid to set min and max attributes on text type inputs. Those attributes are reserved for number type inputs.
@rmccar rmccar added the Bug Something isn't working label Apr 25, 2024
@rmccar rmccar self-assigned this Apr 25, 2024
@rmccar rmccar changed the title Removemin and max HTML attributes for inputs with type set to "text" Remove min and max HTML attributes for inputs with type set to "text" Apr 25, 2024
@rmccar rmccar mentioned this issue Apr 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmccar rmccar

Labels
Bug Something isn't working
Projects
None yet
Milestone
Deliver new iterations of the Design ...
Development

Successfully merging a pull request may close this issue.

Remove min and max attributes from text type inputs ONSdigital/design-system
2 participants
@rmccar @daniellecorke