Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA implementation needs updating #3114

Closed
rmccar opened this issue Mar 26, 2024 · 0 comments · Fixed by #3113
Closed

GA implementation needs updating #3114

rmccar opened this issue Mar 26, 2024 · 0 comments · Fixed by #3113
Assignees
Labels
Bug Something isn't working

Comments

@rmccar
Copy link
Contributor

rmccar commented Mar 26, 2024

The GA implementation needs updating. The gtag function isn't able to be called because it is initialised from within another function and its a function that needs to be setup on the service anyway as part of the GA setup so we shouldn't need to worry about initialising it. It being not initialised by us would mean that the service gets an error in the console as to why analytics wont work in this case which would be helpful.
Also as part of this we should prefix our events with "ons_" to avoid using reserved word events when they are sent to GA.

@rmccar rmccar added the Bug Something isn't working label Mar 26, 2024
@rmccar rmccar self-assigned this Mar 26, 2024
@rmccar rmccar mentioned this issue Mar 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant